From: Laurent Vivier <laurent@vivier.eu>
To: Silvano Cirujano Cuesta <silvano.cirujano-cuesta@siemens.com>,
qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org
Subject: Re: [PATCH v1] scripts: fix generation update-binfmts templates
Date: Fri, 30 Apr 2021 18:46:47 +0200 [thread overview]
Message-ID: <3fe1825b-e5e4-dfd8-b4ce-038bb7aed800@vivier.eu> (raw)
In-Reply-To: <20210323123457.23747-1-silvano.cirujano-cuesta@siemens.com>
Le 23/03/2021 à 13:34, Silvano Cirujano Cuesta a écrit :
> This patch fixes the update-binfmts templates being used in the script
> scripts/qemu-binfmt-conf.sh when the option --debian is used.
>
> Fixed issues are:
> - Typo in flag 'credentials' (previously 'credential').
> - Missing flags 'preserve' and 'fix_binary'.
>
> Reference: https://manpages.debian.org/buster/binfmt-support/update-binfmts.8.en.html#FORMAT_FILES
>
> Signed-off-by: Silvano Cirujano Cuesta <silvano.cirujano-cuesta@siemens.com>
> ---
> scripts/qemu-binfmt-conf.sh | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/qemu-binfmt-conf.sh b/scripts/qemu-binfmt-conf.sh
> index 573b5dc6ac..7de996d536 100755
> --- a/scripts/qemu-binfmt-conf.sh
> +++ b/scripts/qemu-binfmt-conf.sh
> @@ -294,7 +294,9 @@ package qemu-$cpu
> interpreter $qemu
> magic $magic
> mask $mask
> -credential $CREDENTIAL
> +credentials $CREDENTIAL
> +preserve $PRESERVE_ARG0
> +fix_binary $PERSISTENT
> EOF
> }
>
>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
next prev parent reply other threads:[~2021-04-30 17:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 12:34 [PATCH v1] scripts: fix generation update-binfmts templates Silvano Cirujano Cuesta
2021-04-30 16:46 ` Laurent Vivier [this message]
2021-04-30 17:23 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3fe1825b-e5e4-dfd8-b4ce-038bb7aed800@vivier.eu \
--to=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=silvano.cirujano-cuesta@siemens.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).