qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [RFC PATCH] tests/vm: ensure we build everything by default
@ 2024-03-09 11:57 Alex Bennée
  2024-03-11  9:24 ` Thomas Huth
  0 siblings, 1 reply; 2+ messages in thread
From: Alex Bennée @ 2024-03-09 11:57 UTC (permalink / raw)
  To: qemu-devel
  Cc: Alex Bennée, Richard Henderson, Gustavo Romero,
	Philippe Mathieu-Daudé, Thomas Huth,
	Wainer dos Santos Moschetta, Beraldo Leal

The "check" target by itself is not enough to ensure we build the user
mode binaries. While we can't test them with check-tcg we can at least
include them in the build.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Cc: Richard Henderson <richard.henderson@linaro.org>
Cc: Gustavo Romero <gustavo.romero@linaro.org>
---
 tests/vm/basevm.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py
index f8fd751eb1..4a1af04b9a 100644
--- a/tests/vm/basevm.py
+++ b/tests/vm/basevm.py
@@ -606,7 +606,7 @@ def get_default_jobs():
     parser.add_argument("--build-qemu",
                         help="build QEMU from source in guest")
     parser.add_argument("--build-target",
-                        help="QEMU build target", default="check")
+                        help="QEMU build target", default="all check")
     parser.add_argument("--build-path", default=None,
                         help="Path of build directory, "\
                         "for using build tree QEMU binary. ")
-- 
2.39.2



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [RFC PATCH] tests/vm: ensure we build everything by default
  2024-03-09 11:57 [RFC PATCH] tests/vm: ensure we build everything by default Alex Bennée
@ 2024-03-11  9:24 ` Thomas Huth
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Huth @ 2024-03-11  9:24 UTC (permalink / raw)
  To: Alex Bennée, qemu-devel
  Cc: Richard Henderson, Gustavo Romero, Philippe Mathieu-Daudé,
	Wainer dos Santos Moschetta, Beraldo Leal

On 09/03/2024 12.57, Alex Bennée wrote:
> The "check" target by itself is not enough to ensure we build the user
> mode binaries. While we can't test them with check-tcg we can at least
> include them in the build.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Cc: Richard Henderson <richard.henderson@linaro.org>
> Cc: Gustavo Romero <gustavo.romero@linaro.org>
> ---
>   tests/vm/basevm.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)


Reviewed-by: Thomas Huth <thuth@redhat.com>



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-03-11  9:25 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-09 11:57 [RFC PATCH] tests/vm: ensure we build everything by default Alex Bennée
2024-03-11  9:24 ` Thomas Huth

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).