From: Richard Henderson <richard.henderson@linaro.org>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH] target/i386: clean up AAM/AAD
Date: Wed, 22 May 2024 06:39:19 -0700 [thread overview]
Message-ID: <400ce3c8-df33-40a2-9484-06e4e44796ce@linaro.org> (raw)
In-Reply-To: <20240522123912.608497-1-pbonzini@redhat.com>
On 5/22/24 05:39, Paolo Bonzini wrote:
> The 32-bit AAM/AAD opcodes are using helpers that read and write flags and
> env->regs[R_EAX]. Clean them up so that the table correctly includes AX
> as a 16-bit input and output.
>
> No real reason to do it to be honest, but they are nice one-output helpers
> and it removes the masking of env->regs[R_EAX] that generic load/writeback
> code already does.
>
> Signed-off-by: Paolo Bonzini<pbonzini@redhat.com>
> ---
> target/i386/helper.h | 4 ++--
> target/i386/tcg/int_helper.c | 19 ++++++++-----------
> target/i386/tcg/decode-new.c.inc | 4 ++--
> target/i386/tcg/emit.c.inc | 8 ++++----
> 4 files changed, 16 insertions(+), 19 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
prev parent reply other threads:[~2024-05-22 13:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-22 12:39 [PATCH] target/i386: clean up AAM/AAD Paolo Bonzini
2024-05-22 13:39 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=400ce3c8-df33-40a2-9484-06e4e44796ce@linaro.org \
--to=richard.henderson@linaro.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).