* [Qemu-devel] nbd BLOCK_STATUS with -m32
@ 2018-03-26 18:39 Max Reitz
2018-03-26 18:44 ` Eric Blake
0 siblings, 1 reply; 2+ messages in thread
From: Max Reitz @ 2018-03-26 18:39 UTC (permalink / raw)
To: Eric Blake, Vladimir Sementsov-Ogievskiy, Qemu-block
Cc: qemu-devel@nongnu.org
[-- Attachment #1: Type: text/plain, Size: 1000 bytes --]
Hi,
iotests 209 and 123 fail under 32-bit (or at least with -m32), both with
gcc and mingw.
Diff for 209:
@@ -1,2 +1,2 @@
-[{ "start": 0, "length": 524288, "depth": 0, "zero": false, "data": true},
-{ "start": 524288, "length": 524288, "depth": 0, "zero": true, "data":
false}]
+qemu-img: Protocol error: invalid payload for NBD_REPLY_TYPE_BLOCK_STATUS
+qemu-img: Could not read file metadata: Invalid argument
Diff for 123:
@@ -3,6 +3,10 @@
Formatting 'TEST_DIR/source.IMGFMT', fmt=IMGFMT size=1048576
wrote 1048576/1048576 bytes at offset 0
1 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
+qemu-img: Protocol error: invalid payload for NBD_REPLY_TYPE_BLOCK_STATUS
+qemu-img: error getting block status at offset 0: Invalid argument
+qemu-img: error while writing sector 0: Input/output error
+Pattern verification failed at offset 0, 1048576 bytes
read 1048576/1048576 bytes at offset 0
1 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 512 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [Qemu-devel] nbd BLOCK_STATUS with -m32
2018-03-26 18:39 [Qemu-devel] nbd BLOCK_STATUS with -m32 Max Reitz
@ 2018-03-26 18:44 ` Eric Blake
0 siblings, 0 replies; 2+ messages in thread
From: Eric Blake @ 2018-03-26 18:44 UTC (permalink / raw)
To: Max Reitz, Vladimir Sementsov-Ogievskiy, Qemu-block; +Cc: qemu-devel@nongnu.org
On 03/26/2018 01:39 PM, Max Reitz wrote:
> Hi,
>
> iotests 209 and 123 fail under 32-bit (or at least with -m32), both with
> gcc and mingw.
>
> Diff for 209:
>
> @@ -1,2 +1,2 @@
> -[{ "start": 0, "length": 524288, "depth": 0, "zero": false, "data": true},
> -{ "start": 524288, "length": 524288, "depth": 0, "zero": true, "data":
> false}]
> +qemu-img: Protocol error: invalid payload for NBD_REPLY_TYPE_BLOCK_STATUS
> +qemu-img: Could not read file metadata: Invalid argument
>
>
> Diff for 123:
>
> @@ -3,6 +3,10 @@
> Formatting 'TEST_DIR/source.IMGFMT', fmt=IMGFMT size=1048576
> wrote 1048576/1048576 bytes at offset 0
> 1 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
> +qemu-img: Protocol error: invalid payload for NBD_REPLY_TYPE_BLOCK_STATUS
> +qemu-img: error getting block status at offset 0: Invalid argument
Looks to be same root cause; probably an incorrect type promotion or
truncation somewhere. I'll step through the code and submit a patch,
hopefully in time for -rc1.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-26 18:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-26 18:39 [Qemu-devel] nbd BLOCK_STATUS with -m32 Max Reitz
2018-03-26 18:44 ` Eric Blake
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).