From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AB86C48BD6 for ; Thu, 27 Jun 2019 08:36:34 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DB3072082F for ; Thu, 27 Jun 2019 08:36:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DB3072082F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47656 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hgPtR-00077J-5I for qemu-devel@archiver.kernel.org; Thu, 27 Jun 2019 04:36:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53468) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hgPsi-00064E-Hw for qemu-devel@nongnu.org; Thu, 27 Jun 2019 04:35:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hgPsh-0003if-DK for qemu-devel@nongnu.org; Thu, 27 Jun 2019 04:35:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40766) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hgPse-0003eN-VS; Thu, 27 Jun 2019 04:35:45 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A8CBD86674; Thu, 27 Jun 2019 08:35:40 +0000 (UTC) Received: from dhcp-4-67.tlv.redhat.com (dhcp-4-67.tlv.redhat.com [10.35.4.67]) by smtp.corp.redhat.com (Postfix) with ESMTP id E8CBD5D9DE; Thu, 27 Jun 2019 08:35:36 +0000 (UTC) Message-ID: <4015072d8d51cf8a43001cb03722f577216d8df1.camel@redhat.com> From: Maxim Levitsky To: John Snow , qemu-block@nongnu.org, qemu-devel@nongnu.org Date: Thu, 27 Jun 2019 11:35:35 +0300 In-Reply-To: <20190626215301.30733-1-jsnow@redhat.com> References: <20190626215301.30733-1-jsnow@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Thu, 27 Jun 2019 08:35:40 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [Qemu-block] [PATCH] block/qcow: Improve error when opening qcow2 files as qcow X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Qemu-Trivial , Kevin Wolf , radmehrsaeed7@gmail.com, Max Reitz Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, 2019-06-26 at 17:53 -0400, John Snow wrote: > Reported-by: radmehrsaeed7@gmail.com > Fixes: https://bugs.launchpad.net/bugs/1832914 > Signed-off-by: John Snow > --- > block/qcow.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/block/qcow.c b/block/qcow.c > index 6dee5bb792..a9cb6ae0bd 100644 > --- a/block/qcow.c > +++ b/block/qcow.c > @@ -156,7 +156,12 @@ static int qcow_open(BlockDriverState *bs, QDict *options, int flags, > goto fail; > } > if (header.version != QCOW_VERSION) { > - error_setg(errp, "Unsupported qcow version %" PRIu32, header.version); > + error_setg(errp, "qcow (v%d) does not support qcow version %" PRIu32, > + QCOW_VERSION, header.version); > + if (header.version == 2 || header.version == 3) { > + error_append_hint(errp, "Try the 'qcow2' driver instead."); > + } > + > ret = -ENOTSUP; > goto fail; > } Reviewed-by: Maxim Levitsky Best regards, Maxim Levitsky