From: Jeff Cody <jcody@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, stefanha@redhat.com
Subject: [Qemu-devel] [PATCH v8 15/19] block: vhdx - fix comment typos in header, fix incorrect struct fields
Date: Wed, 30 Oct 2013 10:44:52 -0400 [thread overview]
Message-ID: <4031c12a314c8198f4dfbd3d6a08d04b7f41bffb.1383143104.git.jcody@redhat.com> (raw)
In-Reply-To: <cover.1383143104.git.jcody@redhat.com>
In-Reply-To: <cover.1383143104.git.jcody@redhat.com>
VHDXPage83Data and VHDXParentLocatorHeader both incorrectly had their
MSGUID fields set as arrays of 16. This is incorrect (it stems from
an early version where those fields were uint_8 arrays). Those fields
were, up to this patch, unused.
Also, there were a couple of typos and incorrect wording in comments,
and those have been fixed up as well.
Signed-off-by: Jeff Cody <jcody@redhat.com>
---
block/vhdx.h | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/block/vhdx.h b/block/vhdx.h
index 15486c7..f222d18 100644
--- a/block/vhdx.h
+++ b/block/vhdx.h
@@ -58,7 +58,7 @@
typedef struct VHDXFileIdentifier {
uint64_t signature; /* "vhdxfile" in ASCII */
uint16_t creator[256]; /* optional; utf-16 string to identify
- the vhdx file creator. Diagnotistic
+ the vhdx file creator. Diagnostic
only */
} VHDXFileIdentifier;
@@ -114,8 +114,8 @@ typedef struct QEMU_PACKED VHDXHeader {
there is no valid log. If non-zero,
log entries with this guid are
valid. */
- uint16_t log_version; /* version of the log format. Mustn't be
- zero, unless log_guid is also zero */
+ uint16_t log_version; /* version of the log format. Must be
+ set to zero */
uint16_t version; /* version of the vhdx file. Currently,
only supported version is "1" */
uint32_t log_length; /* length of the log. Must be multiple
@@ -281,7 +281,7 @@ typedef struct QEMU_PACKED VHDXVirtualDiskSize {
} VHDXVirtualDiskSize;
typedef struct QEMU_PACKED VHDXPage83Data {
- MSGUID page_83_data[16]; /* unique id for scsi devices that
+ MSGUID page_83_data; /* unique id for scsi devices that
support page 0x83 */
} VHDXPage83Data;
@@ -296,7 +296,7 @@ typedef struct QEMU_PACKED VHDXVirtualDiskPhysicalSectorSize {
} VHDXVirtualDiskPhysicalSectorSize;
typedef struct QEMU_PACKED VHDXParentLocatorHeader {
- MSGUID locator_type[16]; /* type of the parent virtual disk. */
+ MSGUID locator_type; /* type of the parent virtual disk. */
uint16_t reserved;
uint16_t key_value_count; /* number of key/value pairs for this
locator */
--
1.8.3.1
next prev parent reply other threads:[~2013-10-30 14:45 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-30 14:44 [Qemu-devel] [PATCH v8 00/19] VHDX log replay and write support, .bdrv_create() Jeff Cody
2013-10-30 14:44 ` [Qemu-devel] [PATCH v8 01/19] block: vhdx - minor comments and typo correction Jeff Cody
2013-10-30 14:44 ` [Qemu-devel] [PATCH v8 02/19] block: vhdx - add header update capability Jeff Cody
2013-10-30 14:44 ` [Qemu-devel] [PATCH v8 03/19] block: vhdx code movement - VHDXMetadataEntries and BDRVVHDXState to header Jeff Cody
2013-10-30 14:44 ` [Qemu-devel] [PATCH v8 04/19] block: vhdx - log support struct and defines Jeff Cody
2013-10-30 14:44 ` [Qemu-devel] [PATCH v8 05/19] block: vhdx - break endian translation functions out Jeff Cody
2013-10-30 14:44 ` [Qemu-devel] [PATCH v8 06/19] block: vhdx - update log guid in header, and first write tracker Jeff Cody
2013-10-30 14:44 ` [Qemu-devel] [PATCH v8 07/19] block: vhdx code movement - move vhdx_close() above vhdx_open() Jeff Cody
2013-10-30 14:44 ` [Qemu-devel] [PATCH v8 08/19] block: vhdx - log parsing, replay, and flush support Jeff Cody
2013-10-30 14:44 ` [Qemu-devel] [PATCH v8 09/19] block: vhdx - add region overlap detection for image files Jeff Cody
2013-10-30 14:44 ` [Qemu-devel] [PATCH v8 10/19] block: vhdx - add log write support Jeff Cody
2013-10-30 14:44 ` [Qemu-devel] [PATCH v8 11/19] block: vhdx " Jeff Cody
2013-10-30 14:44 ` [Qemu-devel] [PATCH v8 12/19] block: vhdx - remove BAT file offset bit shifting Jeff Cody
2013-10-30 14:44 ` [Qemu-devel] [PATCH v8 13/19] block: vhdx - move more endian translations to vhdx-endian.c Jeff Cody
2013-10-30 14:44 ` [Qemu-devel] [PATCH v8 14/19] block: vhdx - break out code operations to functions Jeff Cody
2013-10-30 14:44 ` Jeff Cody [this message]
2013-10-30 14:44 ` [Qemu-devel] [PATCH v8 16/19] block: vhdx - add .bdrv_create() support Jeff Cody
2013-10-31 13:09 ` Stefan Hajnoczi
2013-10-30 14:44 ` [Qemu-devel] [PATCH v8 17/19] block: vhdx - update _make_test_img() to filter out vhdx options Jeff Cody
2013-10-30 14:44 ` [Qemu-devel] [PATCH v8 18/19] block: qemu-iotests for vhdx, add write test support Jeff Cody
2013-10-30 14:44 ` [Qemu-devel] [PATCH v8 19/19] block: vhdx qemu-iotest - log replay of data sector Jeff Cody
2013-10-31 13:10 ` [Qemu-devel] [PATCH v8 00/19] VHDX log replay and write support, .bdrv_create() Stefan Hajnoczi
2013-11-01 15:32 ` Jeff Cody
2013-11-04 11:41 ` Kevin Wolf
2013-11-01 5:04 ` [Qemu-devel] VHD suport in QEMU? Philipp Hahn
2013-11-01 9:20 ` Stefan Hajnoczi
2013-11-01 11:53 ` Jeff Cody
2013-11-06 14:34 ` [Qemu-devel] [PATCH v8 00/19] VHDX log replay and write support, .bdrv_create() Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4031c12a314c8198f4dfbd3d6a08d04b7f41bffb.1383143104.git.jcody@redhat.com \
--to=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).