From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Liam Merwick <liam.merwick@oracle.com>,
alex.bennee@linaro.org, fam@euphon.net
Cc: qemu-devel@nongnu.org, pbonzini@redhat.com, wainersm@redhat.com,
slp@redhat.com, sgarzare@redhat.com
Subject: Re: [PATCH 3/6] tests/boot_linux_console: fix extract_from_deb() comment
Date: Fri, 31 Jan 2020 01:03:03 +0100 [thread overview]
Message-ID: <403fd74d-eacf-f130-4d4d-c6bcf18d3e96@redhat.com> (raw)
In-Reply-To: <1580142994-1836-4-git-send-email-liam.merwick@oracle.com>
On 1/27/20 5:36 PM, Liam Merwick wrote:
> The second param in extract_from_deb() is 'path' not 'file'
>
> Signed-off-by: Liam Merwick <liam.merwick@oracle.com>
> ---
> tests/acceptance/boot_linux_console.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/acceptance/boot_linux_console.py b/tests/acceptance/boot_linux_console.py
> index 8daf6461ffac..43bc928b03a2 100644
> --- a/tests/acceptance/boot_linux_console.py
> +++ b/tests/acceptance/boot_linux_console.py
> @@ -40,7 +40,7 @@ class BootLinuxConsole(Test):
> Extracts a file from a deb package into the test workdir
>
> :param deb: path to the deb archive
> - :param file: path within the deb archive of the file to be extracted
> + :param path: path within the deb archive of the file to be extracted
> :returns: path of the extracted file
> """
> cwd = os.getcwd()
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Also, applied to my python-next tree:
https://gitlab.com/philmd/qemu/commits/python-next
next prev parent reply other threads:[~2020-01-31 0:03 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-27 16:36 [PATCH 0/6] tests/boot_linux_console: add extra boot acceptance tests Liam Merwick
2020-01-27 16:36 ` [PATCH 1/6] tests/boot_linux_console: add microvm acceptance test Liam Merwick
2020-01-30 11:49 ` Stefano Garzarella
2020-01-30 17:41 ` Wainer dos Santos Moschetta
2020-01-30 23:51 ` Philippe Mathieu-Daudé
2020-01-31 18:10 ` Wainer dos Santos Moschetta
2020-01-27 16:36 ` [PATCH 2/6] tests/boot_linux_console: add BIOS " Liam Merwick
2020-01-30 11:27 ` Stefano Garzarella
2020-01-30 15:34 ` Liam Merwick
2020-01-30 16:28 ` Liam Merwick
2020-01-30 16:45 ` Stefano Garzarella
2020-01-27 16:36 ` [PATCH 3/6] tests/boot_linux_console: fix extract_from_deb() comment Liam Merwick
2020-01-30 11:29 ` Stefano Garzarella
2020-01-30 18:17 ` Wainer dos Santos Moschetta
2020-01-31 0:03 ` Philippe Mathieu-Daudé [this message]
2020-01-27 16:36 ` [PATCH 4/6] travis.yml: install rpm2cpio for acceptance tests Liam Merwick
2020-01-30 12:00 ` Stefano Garzarella
2020-01-27 16:36 ` [PATCH 5/6] tests/boot_linux_console: add extract_from_rpm method Liam Merwick
2020-01-30 12:05 ` Stefano Garzarella
2020-01-30 15:34 ` Liam Merwick
2020-01-30 19:19 ` Wainer dos Santos Moschetta
2020-01-30 23:59 ` Philippe Mathieu-Daudé
2020-01-31 15:02 ` Liam Merwick
2020-02-04 13:31 ` Liam Merwick
2020-02-04 14:22 ` Philippe Mathieu-Daudé
2020-01-27 16:36 ` [PATCH 6/6] tests/boot_linux_console: add PVH acceptance tests Liam Merwick
2020-01-30 12:08 ` Stefano Garzarella
2020-01-30 23:57 ` Philippe Mathieu-Daudé
2020-01-31 15:03 ` Liam Merwick
2020-01-31 15:18 ` Philippe Mathieu-Daudé
2020-01-30 17:57 ` [PATCH 0/6] tests/boot_linux_console: add extra boot " Wainer dos Santos Moschetta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=403fd74d-eacf-f130-4d4d-c6bcf18d3e96@redhat.com \
--to=philmd@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=fam@euphon.net \
--cc=liam.merwick@oracle.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sgarzare@redhat.com \
--cc=slp@redhat.com \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).