From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78676C38A2A for ; Fri, 8 May 2020 13:49:41 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 420D420A8B for ; Fri, 8 May 2020 13:49:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Q+1xOWGo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 420D420A8B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:52142 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jX3Nk-0005Si-E5 for qemu-devel@archiver.kernel.org; Fri, 08 May 2020 09:49:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37790) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jX3Mu-0004fm-3C for qemu-devel@nongnu.org; Fri, 08 May 2020 09:48:48 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:32859 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jX3Mt-0002pS-3F for qemu-devel@nongnu.org; Fri, 08 May 2020 09:48:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588945726; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rrIHL21J/uYm+99Y4mvujVqVBaxWFwNlShzU1FFFlcQ=; b=Q+1xOWGoVaQQFH33xH6VN+5TmZEwJbsYpQXVb0fY7bimpiwqZfn+KSjXyrBuh2q+fzWAo8 72wonooagQyxXTktPtdlKgv0XfI71qIbliP+7UsM95lgiljSBhH2vs7ShY0/pkN7H9TUdj Vyjm4AoNPK41ugB9I8NX2BgY4hu7WJM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-237-oFreP0IrPNOxRbWarjZ_iA-1; Fri, 08 May 2020 09:48:44 -0400 X-MC-Unique: oFreP0IrPNOxRbWarjZ_iA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 43223107ACCA; Fri, 8 May 2020 13:48:43 +0000 (UTC) Received: from [10.3.114.73] (ovpn-114-73.phx2.redhat.com [10.3.114.73]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CD71C60610; Fri, 8 May 2020 13:48:42 +0000 (UTC) Subject: Re: [PATCH v2 2/6] blockdev: Split off basic bitmap operations for qemu-img To: Kevin Wolf References: <20200421212019.170707-1-eblake@redhat.com> <20200421212019.170707-3-eblake@redhat.com> <6ce69bac-9bbc-05fd-e658-89a2ad63a322@redhat.com> <20200508113753.GC4970@linux.fritz.box> From: Eric Blake Organization: Red Hat, Inc. Message-ID: <404776ab-6bb4-1bbe-d9a2-751251c947f2@redhat.com> Date: Fri, 8 May 2020 08:48:42 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200508113753.GC4970@linux.fritz.box> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=207.211.31.81; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/08 01:34:54 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Markus Armbruster , qemu-devel@nongnu.org, qemu-block@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 5/8/20 6:37 AM, Kevin Wolf wrote: >>>> --- >>>> Makefile.objs | 2 +- >>>> include/sysemu/blockdev.h | 14 ++ >>>> blockbitmaps.c | 324 ++++++++++++++++++++++++++++++++++++++ >>> >>> Hm. Can we get a better name? blockdev-bitmaps.c, for example? >> >> Sure, I'm open to bike-shed suggestions. I'd also _really_ love to make the >> new file NOT live in the top-level, but that's a harder task that I'm not >> sure how to do (it's easy to tweak Makefile.objs for another file in the >> same directory, but harder to see through the magic to figure out how to >> relocate things). > > Yes, please move it somewhere else. I'd suggest something like > block/monitor/bitmap-qmp-cmds.c for the QMP command handlers, and if > there are functions that are more generally useful, block/bitmaps.c. > > Instead of modifying the top-level Makefile.objs, you would just edit > block/monitor/Makefile.objs instead and add the filename there. I don't > think you need to understand any magic apart from knowing that is exists > and does what you would expect. Well, you still have to modify the top-level Makefile.objs to tell it to look in the right subdirectories, but I got it figured out finally. v3 will use block/monitor/bitmap-qmp-cmds.c. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org