From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Kv8bR-0004We-9F for qemu-devel@nongnu.org; Wed, 29 Oct 2008 06:48:41 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Kv8bN-0004TS-8w for qemu-devel@nongnu.org; Wed, 29 Oct 2008 06:48:40 -0400 Received: from [199.232.76.173] (port=56158 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Kv8bM-0004TE-T9 for qemu-devel@nongnu.org; Wed, 29 Oct 2008 06:48:37 -0400 Received: from web27207.mail.ukl.yahoo.com ([217.146.182.97]:25269) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1Kv8bM-0003XV-8H for qemu-devel@nongnu.org; Wed, 29 Oct 2008 06:48:36 -0400 Date: Wed, 29 Oct 2008 10:48:31 +0000 (GMT) From: Salvatore Lionetti Subject: Re: [Qemu-devel] TCG on PowerPC arch In-Reply-To: <08F1A495-DAB5-44CD-8993-F1F8CF4470CC@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Message-ID: <405730.48677.qm@web27207.mail.ukl.yahoo.com> Reply-To: salvatorelionetti@yahoo.it, qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?iso-8859-1?Q?Andreas_F=E4rber?= Cc: qemu-devel@nongnu.org Ok, thanks for your review! Perhaps there was a lot of point to change and in the case, do it! One of this is adding emac module in 'Makefile.target' (i forgot it!), but = i think you just patch the patch !# For the italian comment, if it is necessary behead it, or better: globalize= it ;) Serious speaking we have to see at EBC and emulates hw by composing or filt= er readed byte from device. Should be useful an on demand warning per devic= e(in my board fw access@width different from the preset in EBC Bank-i confi= guration register bits 17:18 is considered a bug) All this action should be done for the ppc4xx world. In the mainwhile, for me, you can do anything you want about this read/writ= e callback. On demand i'll adapt the code. For me the main pb, due to my unknowing, is that i'm behind a proxy on Winz= ozz and svn give me timeout. Is the follow command correct? ->svn co svn://svn.sv.gnu.org/qemu/trunk Next time i prefer also test latest svn before submit a patch, in the same = way we do@work, avoiding unecessary work to this group. I'm here for any pb related to this module Thank you for attention Salvatore P.S: For the board, it is a commercial product so don't know if can give de= tail. Moreover i don't thing you need the exact board so, if agree, i creat= e a new board from the previous. P.P.S: In this board there is a way to configure qemu by file. I'd like to = extent such concept, with correct namespace, configuration option. --- Mar 28/10/08, Andreas F=E4rber ha scritto: > Da: Andreas F=E4rber > Oggetto: Re: [Qemu-devel] TCG on PowerPC arch > A: salvatorelionetti@yahoo.it > Cc: qemu-devel@nongnu.org > Data: Marted=EC 28 ottobre 2008, 21:41 > Hi, >=20 > Am 27.10.2008 um 16:29 schrieb Salvatore Lionetti: >=20 > > - Activity [major fix] {vl.c hw/ppc.c} > > reset: unprogram PIT on chip, core, system reset > > focus: initial focus in monitor when load very great > sized elf > > > > I try to attach to svn view. >=20 > Not sure I understand correctly, but this last item seems > to be =20 > missing here. > It would be good if you could check whether your patches > still apply =20 > against the latest SVN version, if that's what you > meant with the =20 > latter. > ppc hardware probably hasn't changed so much since > 0.9.1 but pflash =20 > might have. >=20 > > +static uint32_t emac_readw (void *opaque, > target_phys_addr_t addr) > > +{ > > +=09printf("Lettura a granularita' word su EMAC > " PADDRX "\n",addr); > > +=09return 0; > > +} >=20 > Some Italian slipped in here, also in some comments. > Is the printf maybe a debug leftover that could be removed? >=20 > The split-up of your original patch looks okay, but for > future =20 > submissions it would make review easier if you'd send > only one of them =20 > at a time (e.g., mail subjects [PATCH 1/3], [PATCH 2/3] > etc., see =20 > other examples). >=20 > How did you actually use and test your eMac emulation? I > assume you =20 > did not use a PReP Linux kernel for that? If you could > provide some =20 > details, that might help with testing the TCG conversion > too. >=20 > Andreas=0A=0A=0A Unisciti alla community di Io fotografo e video, il= nuovo corso di fotografia di Gazzetta dello sport:=0Ahttp://www.flickr.com= /groups/iofotografoevideo