From: Thomas Huth <thuth@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-ppc <qemu-ppc@nongnu.org>,
Richard Henderson <rth@twiddle.net>,
BALATON Zoltan <balaton@eik.bme.hu>
Subject: Re: [Qemu-devel] [PATCH] hw/display/cirrus_vga: Add CONFIG option for "isa-cirrus-vga"
Date: Fri, 12 Oct 2018 11:39:26 +0200 [thread overview]
Message-ID: <405b06dd-adb8-2844-15e5-a3b03eb6e0c1@redhat.com> (raw)
In-Reply-To: <20181012093107.xikqvacxhqq7n6bv@sirius.home.kraxel.org>
On 2018-10-12 11:31, Gerd Hoffmann wrote:
> On Thu, Oct 11, 2018 at 05:21:45PM +0200, Thomas Huth wrote:
>> In downstream distros like RHEL we'd like to disable some of the "legacy"
>> devices of QEMU. The ISA version of the Cirrus VGA device is one of these
>> legacy devices. So let's make the build process a little bit more flexible
>> here by putting the Cirrus ISA code into a separate file and by providing
>> a proper CONFIG_VGA_CIRRUS_ISA switch which can be used to disable
>> this device.
>
> We already have a CONFIG_VGA_ISA, how about adding it there instead?
Fine for me, too. I'll send a v2 with that. Note that this will disable
the "isa-cirrus-vga" device on ppc-softmmu and alpha-softmmu, since that
config switch is not use there (while CONFIG_VGA_CIRRUS currently
enables it there). But I assume that's ok since these platforms are
likely only interested in the PCI variant of the Cirrus VGA devices.
Thomas
prev parent reply other threads:[~2018-10-12 9:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-11 15:21 [Qemu-devel] [PATCH] hw/display/cirrus_vga: Add CONFIG option for "isa-cirrus-vga" Thomas Huth
2018-10-11 16:01 ` Philippe Mathieu-Daudé
2018-10-12 9:31 ` Gerd Hoffmann
2018-10-12 9:39 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=405b06dd-adb8-2844-15e5-a3b03eb6e0c1@redhat.com \
--to=thuth@redhat.com \
--cc=balaton@eik.bme.hu \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).