From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BHoum-00083l-S8
	for qemu-devel@nongnu.org; Sun, 25 Apr 2004 15:03:44 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BHouE-0007ih-Kd
	for qemu-devel@nongnu.org; Sun, 25 Apr 2004 15:03:42 -0400
Received: from [193.252.22.22] (helo=mwinf0902.wanadoo.fr)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BHos7-0006RY-Lp
	for qemu-devel@nongnu.org; Sun, 25 Apr 2004 15:00:59 -0400
Received: from bellard.org (ATuileries-112-1-2-230.w80-14.abo.wanadoo.fr
	[80.14.188.230])
	by mwinf0902.wanadoo.fr (SMTP Server) with ESMTP id 685D3180031D
	for <qemu-devel@nongnu.org>; Sun, 25 Apr 2004 21:00:50 +0200 (CEST)
Message-ID: <408C0B60.8030906@bellard.org>
Date: Sun, 25 Apr 2004 21:02:56 +0200
From: Fabrice Bellard <fabrice@bellard.org>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] amd64 compile
References: <Pine.LNX.4.44.0404251715500.31508-100000@wrasse.demon.co.uk>	<1082917248.14652.7.camel@rapid>
	<1082918435.14634.11.camel@rapid>
In-Reply-To: <1082918435.14634.11.camel@rapid>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://mail.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://mail.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

 From the kernel sources, _llseek is handled the same on every arch 
(linux/fs/read_write.c). So there must be another problem.

Fabrice.

J. Mayer wrote:
> ... yet another amd64 fix:
> this one makes PPC binutils run fine on my amd64. 64 bits endianness
> fix...
> There may be more of this kind of bugs...
> 
> 
> 
> ------------------------------------------------------------------------
> 
> Index: linux-user/syscall.c
> ===================================================================
> RCS file: /cvsroot/qemu/qemu/linux-user/syscall.c,v
> retrieving revision 1.47
> diff -u -d -w -B -b -d -p -r1.47 syscall.c
> --- linux-user/syscall.c	12 Apr 2004 20:39:29 -0000	1.47
> +++ linux-user/syscall.c	25 Apr 2004 18:31:36 -0000
> @@ -2403,7 +2403,12 @@ long do_syscall(void *cpu_env, int num, 
>      case TARGET_NR__llseek:
>          {
>              int64_t res;
> +#if defined (__x86_64__)
> +            /* XXX: may be needed by other 64 bits targets ? */
> +            ret = get_errno(_llseek(arg1, arg3, arg2, &res, arg5));
> +#else
>              ret = get_errno(_llseek(arg1, arg2, arg3, &res, arg5));
> +#endif
>              *(int64_t *)arg4 = tswap64(res);
>          }
>          break;