qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Bin Meng <bmeng.cn@gmail.com>, Jason Wang <jasowang@redhat.com>,
	Peter Maydell <peter.maydell@linaro.org>,
	qemu-devel@nongnu.org
Subject: Re: [PATCH v2 02/13] net: Add a 'do_not_pad" to NetClientState
Date: Mon, 15 Mar 2021 10:17:05 +0100	[thread overview]
Message-ID: <4093c094-ed8c-d8c4-09b7-4bad19529ec6@redhat.com> (raw)
In-Reply-To: <20210315075718.5402-3-bmeng.cn@gmail.com>

On 3/15/21 8:57 AM, Bin Meng wrote:
> This adds a flag in NetClientState, so that a net client can tell
> its peer that the packets do not need to be padded to the minimum
> size of an Ethernet frame (60 bytes) before sending to it.
> 
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> ---
> 
>  include/net/net.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/net/net.h b/include/net/net.h
> index 919facaad2..6fab1f83f5 100644
> --- a/include/net/net.h
> +++ b/include/net/net.h
> @@ -100,6 +100,7 @@ struct NetClientState {
>      int vring_enable;
>      int vnet_hdr_len;
>      bool is_netdev;
> +    bool do_not_pad;
>      QTAILQ_HEAD(, NetFilterState) filters;
>  };

This is a bit pointless without the next patch, why
not squash it there?



  reply	other threads:[~2021-03-15  9:28 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-15  7:57 [PATCH v2 00/13] net: Pad short frames for network backends Bin Meng
2021-03-15  7:57 ` [PATCH v2 01/13] net: Add ETH_ZLEN define in eth.h Bin Meng
2021-03-15  9:13   ` Philippe Mathieu-Daudé
2021-03-15 10:15     ` Bin Meng
2021-03-15 10:24       ` Philippe Mathieu-Daudé
2021-03-15  7:57 ` [PATCH v2 02/13] net: Add a 'do_not_pad" to NetClientState Bin Meng
2021-03-15  9:17   ` Philippe Mathieu-Daudé [this message]
2021-03-15  9:18     ` Philippe Mathieu-Daudé
2021-03-15  9:22       ` Philippe Mathieu-Daudé
2021-03-15 10:17         ` Bin Meng
2021-03-15 10:21           ` Peter Maydell
2021-03-15  7:57 ` [PATCH v2 03/13] net: slirp: Pad short frames to minimum size before send Bin Meng
2021-03-16  2:25   ` Jason Wang
2021-03-15  7:57 ` [PATCH v2 04/13] net: tap: " Bin Meng
2021-03-15  7:57 ` [PATCH v2 05/13] hw/net: virtio-net: Initialize nc->do_not_pad to true Bin Meng
2021-03-15  7:57 ` [PATCH v2 06/13] hw/net: e1000: Remove the logic of padding short frames in the receive path Bin Meng
2021-03-15  7:57 ` [PATCH v2 07/13] hw/net: vmxnet3: " Bin Meng
2021-03-15  7:57 ` [PATCH v2 08/13] hw/net: i82596: " Bin Meng
2021-03-15  7:57 ` [PATCH v2 09/13] hw/net: ne2000: " Bin Meng
2021-03-15  7:57 ` [PATCH v2 10/13] hw/net: pcnet: " Bin Meng
2021-03-15  7:57 ` [PATCH v2 11/13] hw/net: rtl8139: " Bin Meng
2021-03-15  7:57 ` [PATCH v2 12/13] hw/net: sungem: " Bin Meng
2021-03-15  7:57 ` [PATCH v2 13/13] hw/net: sunhme: " Bin Meng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4093c094-ed8c-d8c4-09b7-4bad19529ec6@redhat.com \
    --to=philmd@redhat.com \
    --cc=bmeng.cn@gmail.com \
    --cc=jasowang@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).