From: Richard Henderson <richard.henderson@linaro.org>
To: Alexey Baturo <baturo.alexey@gmail.com>
Cc: qemu-riscv@nongnu.org, sagark@eecs.berkeley.edu,
kbastian@mail.uni-paderborn.de, Bin Meng <bin.meng@windriver.com>,
qemu-devel@nongnu.org, space.monkey.delivers@gmail.com,
Alistair.Francis@wdc.com, palmer@dabbelt.com
Subject: Re: [PATCH v11 5/7] [RISCV_PM] Support pointer masking for RISC-V for i/c/f/d/a types of instructions
Date: Fri, 10 Sep 2021 00:00:02 +0200 [thread overview]
Message-ID: <4098b753-76fb-2dad-4922-837061184fc1@linaro.org> (raw)
In-Reply-To: <20210909190033.1339448-6-space.monkey.delivers@gmail.com>
On 9/9/21 9:00 PM, Alexey Baturo wrote:
> +++ b/target/riscv/insn_trans/trans_rva.c.inc
> @@ -25,6 +25,7 @@ static bool gen_lr(DisasContext *ctx, arg_atomic *a, MemOp mop)
> if (a->rl) {
> tcg_gen_mb(TCG_MO_ALL | TCG_BAR_STRL);
> }
> + gen_pm_adjust_address(ctx, src1, src1);
This will not work anymore, since src1 may not be a temporary. See the use of temp_new()
e.g. in gen_load(). We're currently only conditionally allocating a temporary; with this
extension, we'll always need one. So it is probably worth cleaning that up at this time.
r~
next prev parent reply other threads:[~2021-09-09 22:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-09 19:00 [PATCH v11 0/7] RISC-V Pointer Masking implementation Alexey Baturo
2021-09-09 19:00 ` [PATCH v11 1/7] [RISCV_PM] Add J-extension into RISC-V Alexey Baturo
2021-09-10 7:15 ` Bin Meng
2021-09-09 19:00 ` [PATCH v11 2/7] [RISCV_PM] Add CSR defines for RISC-V PM extension Alexey Baturo
2021-09-09 19:00 ` [PATCH v11 3/7] [RISCV_PM] Support CSRs required for RISC-V PM extension except for the h-mode Alexey Baturo
2021-09-09 19:00 ` [PATCH v11 4/7] [RISCV_PM] Print new PM CSRs in QEMU logs Alexey Baturo
2021-09-09 19:00 ` [PATCH v11 5/7] [RISCV_PM] Support pointer masking for RISC-V for i/c/f/d/a types of instructions Alexey Baturo
2021-09-09 22:00 ` Richard Henderson [this message]
2021-09-18 5:08 ` Alexey Baturo
2021-09-09 19:00 ` [PATCH v11 6/7] [RISCV_PM] Implement address masking functions required for RISC-V Pointer Masking extension Alexey Baturo
2021-09-09 19:00 ` [PATCH v11 7/7] [RISCV_PM] Allow experimental J-ext to be turned on Alexey Baturo
2021-09-10 7:14 ` Bin Meng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4098b753-76fb-2dad-4922-837061184fc1@linaro.org \
--to=richard.henderson@linaro.org \
--cc=Alistair.Francis@wdc.com \
--cc=baturo.alexey@gmail.com \
--cc=bin.meng@windriver.com \
--cc=kbastian@mail.uni-paderborn.de \
--cc=palmer@dabbelt.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=sagark@eecs.berkeley.edu \
--cc=space.monkey.delivers@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).