From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.33)
	id 1BMP2B-0001Uv-Sz
	for qemu-devel@nongnu.org; Sat, 08 May 2004 06:26:20 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.33)
	id 1BMP1d-0001Lc-Ne
	for qemu-devel@nongnu.org; Sat, 08 May 2004 06:26:17 -0400
Received: from [193.252.22.22] (helo=mwinf0903.wanadoo.fr)
	by monty-python.gnu.org with esmtp (Exim 4.33) id 1BMP1c-0001LH-TS
	for qemu-devel@nongnu.org; Sat, 08 May 2004 06:25:45 -0400
Received: from bellard.org (ATuileries-112-1-3-204.w81-48.abo.wanadoo.fr
	[81.48.134.204])
	by mwinf0903.wanadoo.fr (SMTP Server) with ESMTP id 53D5F18001AD
	for <qemu-devel@nongnu.org>; Sat,  8 May 2004 12:25:43 +0200 (CEST)
Message-ID: <409CB62B.4040303@bellard.org>
Date: Sat, 08 May 2004 12:27:55 +0200
From: Fabrice Bellard <fabrice@bellard.org>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] QEMU RFB (vnc) driver
References: <1083291721.28997.11.camel@matt>
	<4098B29B.5020108@wasp.net.au>	<409933A2.3010100@bellard.org>
	<Pine.LNX.4.58.0405052226060.1313@wgmdd8.biozentrum.uni-wuerzburg.de>
In-Reply-To: <Pine.LNX.4.58.0405052226060.1313@wgmdd8.biozentrum.uni-wuerzburg.de>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://mail.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://mail.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Some comments about your patch:

- The configure option '--enable-vnc-and-sdl' must be suppressed. QEMU 
can handle several display interfaces (it has already two). So it is 
better to add a command line option '-vnc' to QEMU to select the VNC 
server display. Another command line option can be added to have both 
sdl and vnc display. Having configure time options _must_ be avoided as 
most users won't recompile QEMU.

- An option '-k keyb_type' must be added to select the type of keyboard.

Fabrice.

Johannes Schindelin wrote:
> Hi,
> 
> First of all: QEMU is wonderful. It is blazingly fast, yet very small!
> 
> Second, my sincere apologies to Matthew: I hacked together my own version
> of what you did. Attached is a patch which does about the same thing.
> 
> A few differences, though:
> 
> 	- I stole a bit from wine, so I have a compile time choice of a
> 	  keymap. This certainly has room to improve.
> 
> 	- I actually change the screen resolution. There is support for
> 	  this in LibVNCServer since version 0.4, and a few clients
> 	  support it. If the client does not support the change, a warning
> 	  is issued.
> 
> 	- It is configurable:
> 		./configure --enable-vnc
> 	  will change the output completely to vnc, and
> 		./configure --enable-vnc-and-sdl
> 	  will use both simultaneously!
> 
> 	- It still contains debug messages for every key you hit (it also
> 	  has those messages in SDL so I can work out why VNC behaves
> 	  differently).