From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9004AC4345F for ; Wed, 24 Apr 2024 17:54:55 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rzgpG-0001cD-Uk; Wed, 24 Apr 2024 13:54:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rzgpB-0001bL-91 for qemu-devel@nongnu.org; Wed, 24 Apr 2024 13:54:29 -0400 Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rzgp8-0007LI-U0 for qemu-devel@nongnu.org; Wed, 24 Apr 2024 13:54:28 -0400 Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-349545c3eb8so48566f8f.2 for ; Wed, 24 Apr 2024 10:54:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1713981265; x=1714586065; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=z3P1jKumN/2f0w+S1BnkZarrfCBd03HH4eddYEKpnIg=; b=UGWWk4wO4h6vdW1RzVKXKb7X4NSH4lxw1wUu/Zf8xOyNAe1R8017zmtAsMHChOE42o kkbY43FijOzTde4Njk+3fu8XY7ladI9ExjTVKojnl9CtdGxdy2Z4zKzxYykv4SVDkbPw AvtmkNr7GF60nyspX1c+Xecmz4m0N2oDqReCD3HUH6jOFfhu1NDJjqR0Hb3ASggOZrpn ML7gZQp9HFvblAn46eT/49jWe7kEA++Gz5Zq62km0JM4HKEauXhQGBtXUAFyj7WJuDo5 D5eWtIJTsWHNTq5YE5U+azSS2Bt0WCg+Ixuxzt0GdsKKMVQdTkfrK6/N+V/wHO0+aK7B hong== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713981265; x=1714586065; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=z3P1jKumN/2f0w+S1BnkZarrfCBd03HH4eddYEKpnIg=; b=CMRnzLk6yxGlBI5jTWVbpfoCt31QfoyPsr5XlkpqqgBJB51qNzk6qEjQdtsuF7E7Ry JOUDL66vaCeJbW3bYnhBrhNXLbHqdZJuihSWrqlAok5U2gILX2k3BThozhrvvjW24gno 5TK3LodRDuuNaydzOfEyRmwYGr1i5EaAkkDm0A/HrUa2KquUV/wRYN8esKRBZHD4M0aH uY3vmNPQLKryrvt0SNy51bpAKDTKecynQal6NA4V6JywNmbPhKt+C85sr7HBilj620p2 Z9l+11X3nIiPRzr2Kq1LDLL8O4q7M9wshvvXNSa29nwQE59jzgKpPmZsxVAeRKlcXJlI 7y8A== X-Forwarded-Encrypted: i=1; AJvYcCU8NLcoHTxoHi+cy31BIaTI22UG8/Mt1xWKViBxM7qaRPxEYRee6AD0PB+d6ZTQ1PA1WeklMCT+tCpQkqEdrg3nZw6422A= X-Gm-Message-State: AOJu0YzdurDN6yst4nscAk1TPKOiUxiDeZUQJ+Cjuf+3Rz2yipkESr0R aT1WIzPy0ZplPiMWgdrViWyhz0kd7Gea0O6ujCGMUu9gY1zgFos6NWgzkZFax8o= X-Google-Smtp-Source: AGHT+IFmIodfRftbVOhvB2rYpm7nOqzp1jhLDBa+AeynyBeo/vuHfmY814JY+lmYeHpY5XtHdnoPCg== X-Received: by 2002:adf:b11a:0:b0:34a:4e2:7014 with SMTP id l26-20020adfb11a000000b0034a04e27014mr2182476wra.35.1713981265284; Wed, 24 Apr 2024 10:54:25 -0700 (PDT) Received: from [192.168.1.102] (mon75-h03-176-184-51-42.dsl.sta.abo.bbox.fr. [176.184.51.42]) by smtp.gmail.com with ESMTPSA id o12-20020a5d684c000000b0034aa1e534c2sm12314832wrw.96.2024.04.24.10.54.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Apr 2024 10:54:24 -0700 (PDT) Message-ID: <409f547e-fdab-4183-8f9a-9852f9be34f6@linaro.org> Date: Wed, 24 Apr 2024 19:54:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] target/riscv/kvm: remove sneaky strerrorname_np() instance To: Daniel Henrique Barboza , qemu-devel@nongnu.org Cc: qemu-riscv@nongnu.org, alistair.francis@wdc.com, bmeng@tinylab.org, liwei1518@gmail.com, zhiwei_liu@linux.alibaba.com, palmer@rivosinc.com, thuth@redhat.com, alex.bennee@linaro.org, mjt@tls.msk.ru, ajones@ventanamicro.com References: <20240424094700.453356-1-dbarboza@ventanamicro.com> <20240424094700.453356-2-dbarboza@ventanamicro.com> <82079170-9d82-46d5-81e4-44d3b38b551f@linaro.org> Content-Language: en-US From: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::42c; envelope-from=philmd@linaro.org; helo=mail-wr1-x42c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 24/4/24 19:18, Daniel Henrique Barboza wrote: > On 4/24/24 06:55, Philippe Mathieu-Daudé wrote: >> On 24/4/24 11:46, Daniel Henrique Barboza wrote: >>> Commit d424db2354 excluded some strerrorname_np() instances because they >>> break musl libc builds. Another instance happened to slip by via commit >>> d4ff3da8f4. >>> >>> Remove it before it causes trouble again. >>> >>> Fixes: d4ff3da8f4 (target/riscv/kvm: initialize 'vlenb' via >>> get-reg-list) >>> Signed-off-by: Daniel Henrique Barboza >>> --- >>>   target/riscv/kvm/kvm-cpu.c | 4 ++-- >>>   1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/target/riscv/kvm/kvm-cpu.c b/target/riscv/kvm/kvm-cpu.c >>> index 6a6c6cae80..ee69ea9785 100644 >>> --- a/target/riscv/kvm/kvm-cpu.c >>> +++ b/target/riscv/kvm/kvm-cpu.c >>> @@ -1054,8 +1054,8 @@ static void kvm_riscv_read_vlenb(RISCVCPU *cpu, >>> KVMScratchCPU *kvmcpu, >>>           ret = ioctl(kvmcpu->cpufd, KVM_GET_ONE_REG, ®); >>>           if (ret != 0) { >>> -            error_report("Unable to read vlenb register, error code: >>> %s", >>> -                         strerrorname_np(errno)); >>> +            error_report("Unable to read vlenb register, error code: >>> %d", >>> +                         errno); >> >> Why not use "%s" strerror(errno)? > > It's not exactly the same. For errno = 2 strerrorname_np() gives > "ENOENT", and > sterror() gives "No such file or directory". In this particular context > I think > just printing a "error code -2" is clearer because we're not mentioning > files and > dirs in a KVM reg context. > > But in the end I don't mind changing to strerror() if you feel strong > about it. It's > fine either way. I'm fine with "error code -2" ;) Regards, Phil.