From: Fabrice Bellard <fabrice@bellard.org>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] security_20040618
Date: Sat, 19 Jun 2004 17:44:52 +0200 [thread overview]
Message-ID: <40D45F74.9010701@bellard.org> (raw)
In-Reply-To: <20040618184036.GA1874@sentinelchicken.org>
Tim wrote:
> Updates to this, from the previous version two days ago, include
> additional strcpy replacements, as well as TODO comments pointing out
> unhealthy calls to {m,re}alloc, which don't check for NULL return
> values. (I am not sure how to handle error return codes in most places,
> so just comments for now.) Also pstrcpy() in vl.c was simplified, but
> should behave exactly the same as before.
Thank you for the fixes.
For malloc() returning NULL, if your patch just says "malloc error", I
don't consider it is a good fix.
I see that you added many snprintf(). I don't like that because
pstrcpy() does exactly the right thing and it is faster and simpler.
Fabrice.
next prev parent reply other threads:[~2004-06-19 15:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-18 18:40 [Qemu-devel] [PATCH] security_20040618 Tim
2004-06-19 9:11 ` Gianni Tedesco
2004-06-19 15:19 ` Tim
2004-06-19 15:26 ` Gianni Tedesco
2004-06-19 15:44 ` Fabrice Bellard [this message]
2004-06-19 16:01 ` Tim
2004-06-19 17:11 ` Fabrice Bellard
[not found] <200406181841.i5IIfZQa019337@treas.simtreas.ru>
2004-06-19 7:37 ` Vladimir N. Oleynik
2004-06-19 15:05 ` Tim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40D45F74.9010701@bellard.org \
--to=fabrice@bellard.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).