From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1BbjLq-0008BE-Rr for qemu-devel@nongnu.org; Sat, 19 Jun 2004 13:09:58 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1BbjLp-00089P-BR for qemu-devel@nongnu.org; Sat, 19 Jun 2004 13:09:58 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1BbjLp-00089E-8j for qemu-devel@nongnu.org; Sat, 19 Jun 2004 13:09:57 -0400 Received: from [193.252.22.25] (helo=mwinf0602.wanadoo.fr) by monty-python.gnu.org with esmtp (Exim 4.34) id 1BbjKP-0001Lx-I0 for qemu-devel@nongnu.org; Sat, 19 Jun 2004 13:08:29 -0400 Received: from bellard.org (ATuileries-112-1-3-108.w81-48.abo.wanadoo.fr [81.48.134.108]) by mwinf0602.wanadoo.fr (SMTP Server) with ESMTP id C4706540035A for ; Sat, 19 Jun 2004 19:08:28 +0200 (CEST) Message-ID: <40D473A6.6020402@bellard.org> Date: Sat, 19 Jun 2004 19:11:02 +0200 From: Fabrice Bellard MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] security_20040618 References: <20040618184036.GA1874@sentinelchicken.org> <40D45F74.9010701@bellard.org> <20040619160134.GD1962@sentinelchicken.org> In-Reply-To: <20040619160134.GD1962@sentinelchicken.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Tim wrote: > Were you able to look at my proposed changes to pstrcpy()? What do you > think of them? An advice: _never_ use strncpy, it never does what you think it does ! [Your patch is not correct as it adds a lot of zeros at the end of the buffer, which is not the intended behaviour of pstrcpy]. Fabrice.