[Qemu-devel] Re: [PATCH] linux-user sysinfo support & do_sigreturn fix for i386-user

[Qemu-devel] Re: [PATCH] linux-user sysinfo support & do_sigreturn fix for i386-user

[François Guimond]

Fabrice Bellard wrote:

>The code was buggy, but your patch is still not correct. I tried to make a 
>correction. Try it !

Just tried it with strace and it looks good, no sigprocmask incoherence 
present.

>OK. A small note: it is better now to use __get_user() and __put_user() to 
>access to the target memory.

Will do if I submit future patches (I wasn't aware of those functions at the 
time, only found out about them later when I was trying to fix 
do_sigreturn).

Minor, is there any work being done or planned to support the i386 syscalls 
149 and 252?  (I think it corresponds to sysctl and exit_group)  My 
application still complains about those, although they don't seem to affect 
operation of the program (well, the lack of exit_group does cause problems 
quitting it, but nothing a kill can't fix..).


-Francois

_________________________________________________________________
Free yourself from those irritating pop-up ads with MSn Premium. Get 2months 
FREE*  
http://join.msn.com/?pgmarket=en-ca&page=byoa/prem&xAPID=1994&DI=1034&SU=http://hotmail.com/enca&HL=Market_MSNIS_Taglines

Re: [Qemu-devel] Re: [PATCH] linux-user sysinfo support & do_sigreturn fix for i386-user

[Fabrice Bellard]

François Guimond wrote:
> 
> Fabrice Bellard wrote:
> 
>> The code was buggy, but your patch is still not correct. I tried to 
>> make a correction. Try it !
> 
> 
> Just tried it with strace and it looks good, no sigprocmask incoherence 
> present.

Good.

>[...]

> Minor, is there any work being done or planned to support the i386 
> syscalls 149 and 252?  (I think it corresponds to sysctl and 
> exit_group)  My application still complains about those, although they 
> don't seem to affect operation of the program (well, the lack of 
> exit_group does cause problems quitting it, but nothing a kill can't 
> fix..).

exit_group() may not be implemented on < 2.6 kernels. A patch was 
submitted some time ago for some functions of sysctl, but I never took 
the time to merge it.

Fabrice.