From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Cc: "Hervé Poussineau" <hpoussin@reactos.org>,
"Gerd Hoffmann" <kraxel@redhat.com>
Subject: Re: [PATCH v2 4/4] hw/mips/jazz: Inline vga_mmio_init() and remove it
Date: Mon, 13 Dec 2021 11:15:36 +0100 [thread overview]
Message-ID: <40b21d90-36ef-1b0a-a68e-32be46de4ac7@redhat.com> (raw)
In-Reply-To: <20211206224528.563588-5-f4bug@amsat.org>
On 06/12/2021 23.45, Philippe Mathieu-Daudé wrote:
> vga_mmio_init() is used only one time and not very helpful,
> inline and remove it.
>
> Reviewed-by: BALATON Zoltan <balaton@eik.bme.hu>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> include/hw/display/vga.h | 5 -----
> hw/display/vga-mmio.c | 19 -------------------
> hw/mips/jazz.c | 9 ++++++++-
> 3 files changed, 8 insertions(+), 25 deletions(-)
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2021-12-13 10:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-06 22:45 [PATCH v2 0/4] hw/display: QOM'ify vga_mmio_init() as TYPE_VGA_MMIO Philippe Mathieu-Daudé
2021-12-06 22:45 ` [PATCH v2 1/4] hw/display: Rename VGA_ISA_MM -> VGA_MMIO Philippe Mathieu-Daudé
2021-12-06 22:45 ` [PATCH v2 2/4] hw/display/vga-mmio: Inline vga_mm_init() Philippe Mathieu-Daudé
2021-12-06 22:45 ` [PATCH v2 3/4] hw/display/vga-mmio: QOM'ify vga_mmio_init() as TYPE_VGA_MMIO Philippe Mathieu-Daudé
2021-12-13 10:48 ` Thomas Huth
2021-12-13 11:05 ` Philippe Mathieu-Daudé
2021-12-13 22:46 ` Mark Cave-Ayland
2021-12-14 12:05 ` Juan Quintela
2021-12-14 12:52 ` Daniel P. Berrangé
2021-12-14 13:07 ` Philippe Mathieu-Daudé
2021-12-06 22:45 ` [PATCH v2 4/4] hw/mips/jazz: Inline vga_mmio_init() and remove it Philippe Mathieu-Daudé
2021-12-13 10:15 ` Thomas Huth [this message]
2021-12-13 9:53 ` [PATCH v2 0/4] hw/display: QOM'ify vga_mmio_init() as TYPE_VGA_MMIO Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40b21d90-36ef-1b0a-a68e-32be46de4ac7@redhat.com \
--to=thuth@redhat.com \
--cc=f4bug@amsat.org \
--cc=hpoussin@reactos.org \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).