Re: [PATCH 2/5] tests/functional: remove unused 'bin_prefix' variable

[Thomas Huth <thuth@redhat.com>]

On 05/02/2025 16.59, Daniel P. Berrangé wrote:
> This was copied over from avocado but has not been used in the new
> functional tests.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>   tests/functional/qemu_test/testcase.py | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/functional/qemu_test/testcase.py b/tests/functional/qemu_test/testcase.py
> index 94541e8bfb..332c782ebc 100644
> --- a/tests/functional/qemu_test/testcase.py
> +++ b/tests/functional/qemu_test/testcase.py
> @@ -192,7 +192,7 @@ def assets_available(self):
>                       return False
>           return True
>   
> -    def setUp(self, bin_prefix):
> +    def setUp(self):
>           if self.qemu_bin is None:
>               self.skipTest("QEMU_TEST_QEMU_BINARY env variable is not set")
>   
> @@ -256,7 +256,7 @@ def main():
>   class QemuUserTest(QemuBaseTest):
>   
>       def setUp(self):
> -        super().setUp('qemu-')
> +        super().setUp()
>           self._ldpath = []
>   
>       def add_ldpath(self, ldpath):
> @@ -279,7 +279,7 @@ class QemuSystemTest(QemuBaseTest):
>       def setUp(self):
>           self._vms = {}
>   
> -        super().setUp('qemu-system-')
> +        super().setUp()

We might still need it in case we try to add auto-detection of the QEMU 
binary again, but yes, for the time being:

Reviewed-by: Thomas Huth <thuth@redhat.com>