From: Max Reitz <mreitz@redhat.com>
To: qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH] iotests/common.pattern: Quote echos
Date: Tue, 7 Apr 2020 10:59:27 +0200 [thread overview]
Message-ID: <40bbb898-ff15-f68c-35e4-40f6bc119638@redhat.com> (raw)
In-Reply-To: <20200403101134.805871-1-mreitz@redhat.com>
[-- Attachment #1.1: Type: text/plain, Size: 617 bytes --]
On 03.04.20 12:11, Max Reitz wrote:
> From time to time, my shell decides to repace the bracketed numbers here
> by the numbers inside (i.e., "=== Clusters to be compressed [1]" is
> printed as "=== Clusters to be compressed 1"). That makes tests that
> use common.pattern fail. Prevent that from happening by quoting the
> arguments to all echos in common.pattern.
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
> tests/qemu-iotests/common.pattern | 22 +++++++++++-----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
Thanks for the reviews, applied to my block branch.
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2020-04-07 9:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 10:11 [PATCH] iotests/common.pattern: Quote echos Max Reitz
2020-04-03 10:20 ` Philippe Mathieu-Daudé
2020-04-03 13:39 ` Eric Blake
2020-04-07 8:59 ` Max Reitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40bbb898-ff15-f68c-35e4-40f6bc119638@redhat.com \
--to=mreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).