* [Qemu-devel] [PATCH] s390/ipl: cast to SCSIDevice directly
2019-05-02 15:55 [Qemu-devel] [PATCH] s390/ipl: cast to SCSIDevice directly Cornelia Huck
@ 2019-05-02 15:55 ` Cornelia Huck
2019-05-02 15:59 ` Thomas Huth
` (3 subsequent siblings)
4 siblings, 0 replies; 10+ messages in thread
From: Cornelia Huck @ 2019-05-02 15:55 UTC (permalink / raw)
To: Thomas Huth, Christian Borntraeger
Cc: Jason J . Herne, qemu-s390x, Cornelia Huck, qemu-devel
Coverity notes that the result of object_dynamic_cast() to
SCSIDevice is not checked in s390_gen_initial_iplp(); as
we know that we always have a SCSIDevice in that branch,
we can instead cast via SCSI_DEVICE directly.
Coverity: CID 1401098
Fixes: 44445d8668f4 ("s390 vfio-ccw: Add bootindex property and IPLB data")
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
---
hw/s390x/ipl.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c
index d0cc06a05fd0..b93750c14eac 100644
--- a/hw/s390x/ipl.c
+++ b/hw/s390x/ipl.c
@@ -374,8 +374,7 @@ static bool s390_gen_initial_iplb(S390IPLState *ipl)
if (ccw_dev) {
switch (devtype) {
case CCW_DEVTYPE_SCSI:
- sd = (SCSIDevice *) object_dynamic_cast(OBJECT(dev_st),
- TYPE_SCSI_DEVICE);
+ sd = SCSI_DEVICE(dev_st);
ipl->iplb.len = cpu_to_be32(S390_IPLB_MIN_QEMU_SCSI_LEN);
ipl->iplb.blk0_len =
cpu_to_be32(S390_IPLB_MIN_QEMU_SCSI_LEN - S390_IPLB_HEADER_LEN);
--
2.17.2
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [Qemu-devel] [PATCH] s390/ipl: cast to SCSIDevice directly
2019-05-02 15:55 [Qemu-devel] [PATCH] s390/ipl: cast to SCSIDevice directly Cornelia Huck
2019-05-02 15:55 ` Cornelia Huck
@ 2019-05-02 15:59 ` Thomas Huth
2019-05-02 15:59 ` Thomas Huth
2019-05-02 16:10 ` Philippe Mathieu-Daudé
` (2 subsequent siblings)
4 siblings, 1 reply; 10+ messages in thread
From: Thomas Huth @ 2019-05-02 15:59 UTC (permalink / raw)
To: Cornelia Huck, Christian Borntraeger
Cc: qemu-s390x, qemu-devel, Jason J . Herne
On 02/05/2019 17.55, Cornelia Huck wrote:
> Coverity notes that the result of object_dynamic_cast() to
> SCSIDevice is not checked in s390_gen_initial_iplp(); as
> we know that we always have a SCSIDevice in that branch,
> we can instead cast via SCSI_DEVICE directly.
>
> Coverity: CID 1401098
> Fixes: 44445d8668f4 ("s390 vfio-ccw: Add bootindex property and IPLB data")
> Signed-off-by: Cornelia Huck <cohuck@redhat.com>
> ---
> hw/s390x/ipl.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c
> index d0cc06a05fd0..b93750c14eac 100644
> --- a/hw/s390x/ipl.c
> +++ b/hw/s390x/ipl.c
> @@ -374,8 +374,7 @@ static bool s390_gen_initial_iplb(S390IPLState *ipl)
> if (ccw_dev) {
> switch (devtype) {
> case CCW_DEVTYPE_SCSI:
> - sd = (SCSIDevice *) object_dynamic_cast(OBJECT(dev_st),
> - TYPE_SCSI_DEVICE);
> + sd = SCSI_DEVICE(dev_st);
> ipl->iplb.len = cpu_to_be32(S390_IPLB_MIN_QEMU_SCSI_LEN);
> ipl->iplb.blk0_len =
> cpu_to_be32(S390_IPLB_MIN_QEMU_SCSI_LEN - S390_IPLB_HEADER_LEN);
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [Qemu-devel] [PATCH] s390/ipl: cast to SCSIDevice directly
2019-05-02 15:59 ` Thomas Huth
@ 2019-05-02 15:59 ` Thomas Huth
0 siblings, 0 replies; 10+ messages in thread
From: Thomas Huth @ 2019-05-02 15:59 UTC (permalink / raw)
To: Cornelia Huck, Christian Borntraeger
Cc: Jason J . Herne, qemu-s390x, qemu-devel
On 02/05/2019 17.55, Cornelia Huck wrote:
> Coverity notes that the result of object_dynamic_cast() to
> SCSIDevice is not checked in s390_gen_initial_iplp(); as
> we know that we always have a SCSIDevice in that branch,
> we can instead cast via SCSI_DEVICE directly.
>
> Coverity: CID 1401098
> Fixes: 44445d8668f4 ("s390 vfio-ccw: Add bootindex property and IPLB data")
> Signed-off-by: Cornelia Huck <cohuck@redhat.com>
> ---
> hw/s390x/ipl.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c
> index d0cc06a05fd0..b93750c14eac 100644
> --- a/hw/s390x/ipl.c
> +++ b/hw/s390x/ipl.c
> @@ -374,8 +374,7 @@ static bool s390_gen_initial_iplb(S390IPLState *ipl)
> if (ccw_dev) {
> switch (devtype) {
> case CCW_DEVTYPE_SCSI:
> - sd = (SCSIDevice *) object_dynamic_cast(OBJECT(dev_st),
> - TYPE_SCSI_DEVICE);
> + sd = SCSI_DEVICE(dev_st);
> ipl->iplb.len = cpu_to_be32(S390_IPLB_MIN_QEMU_SCSI_LEN);
> ipl->iplb.blk0_len =
> cpu_to_be32(S390_IPLB_MIN_QEMU_SCSI_LEN - S390_IPLB_HEADER_LEN);
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Qemu-devel] [PATCH] s390/ipl: cast to SCSIDevice directly
2019-05-02 15:55 [Qemu-devel] [PATCH] s390/ipl: cast to SCSIDevice directly Cornelia Huck
2019-05-02 15:55 ` Cornelia Huck
2019-05-02 15:59 ` Thomas Huth
@ 2019-05-02 16:10 ` Philippe Mathieu-Daudé
2019-05-02 16:10 ` Philippe Mathieu-Daudé
2019-05-02 17:49 ` Christian Borntraeger
2019-05-03 8:09 ` Cornelia Huck
4 siblings, 1 reply; 10+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-05-02 16:10 UTC (permalink / raw)
To: Cornelia Huck, Thomas Huth, Christian Borntraeger
Cc: Jason J . Herne, qemu-s390x, qemu-devel
On 5/2/19 5:55 PM, Cornelia Huck wrote:
> Coverity notes that the result of object_dynamic_cast() to
> SCSIDevice is not checked in s390_gen_initial_iplp(); as
> we know that we always have a SCSIDevice in that branch,
> we can instead cast via SCSI_DEVICE directly.
>
> Coverity: CID 1401098
> Fixes: 44445d8668f4 ("s390 vfio-ccw: Add bootindex property and IPLB data")
> Signed-off-by: Cornelia Huck <cohuck@redhat.com>
> ---
> hw/s390x/ipl.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c
> index d0cc06a05fd0..b93750c14eac 100644
> --- a/hw/s390x/ipl.c
> +++ b/hw/s390x/ipl.c
> @@ -374,8 +374,7 @@ static bool s390_gen_initial_iplb(S390IPLState *ipl)
> if (ccw_dev) {
> switch (devtype) {
> case CCW_DEVTYPE_SCSI:
> - sd = (SCSIDevice *) object_dynamic_cast(OBJECT(dev_st),
> - TYPE_SCSI_DEVICE);
> + sd = SCSI_DEVICE(dev_st);
> ipl->iplb.len = cpu_to_be32(S390_IPLB_MIN_QEMU_SCSI_LEN);
> ipl->iplb.blk0_len =
> cpu_to_be32(S390_IPLB_MIN_QEMU_SCSI_LEN - S390_IPLB_HEADER_LEN);
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [Qemu-devel] [PATCH] s390/ipl: cast to SCSIDevice directly
2019-05-02 16:10 ` Philippe Mathieu-Daudé
@ 2019-05-02 16:10 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 10+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-05-02 16:10 UTC (permalink / raw)
To: Cornelia Huck, Thomas Huth, Christian Borntraeger
Cc: Jason J . Herne, qemu-s390x, qemu-devel
On 5/2/19 5:55 PM, Cornelia Huck wrote:
> Coverity notes that the result of object_dynamic_cast() to
> SCSIDevice is not checked in s390_gen_initial_iplp(); as
> we know that we always have a SCSIDevice in that branch,
> we can instead cast via SCSI_DEVICE directly.
>
> Coverity: CID 1401098
> Fixes: 44445d8668f4 ("s390 vfio-ccw: Add bootindex property and IPLB data")
> Signed-off-by: Cornelia Huck <cohuck@redhat.com>
> ---
> hw/s390x/ipl.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c
> index d0cc06a05fd0..b93750c14eac 100644
> --- a/hw/s390x/ipl.c
> +++ b/hw/s390x/ipl.c
> @@ -374,8 +374,7 @@ static bool s390_gen_initial_iplb(S390IPLState *ipl)
> if (ccw_dev) {
> switch (devtype) {
> case CCW_DEVTYPE_SCSI:
> - sd = (SCSIDevice *) object_dynamic_cast(OBJECT(dev_st),
> - TYPE_SCSI_DEVICE);
> + sd = SCSI_DEVICE(dev_st);
> ipl->iplb.len = cpu_to_be32(S390_IPLB_MIN_QEMU_SCSI_LEN);
> ipl->iplb.blk0_len =
> cpu_to_be32(S390_IPLB_MIN_QEMU_SCSI_LEN - S390_IPLB_HEADER_LEN);
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Qemu-devel] [PATCH] s390/ipl: cast to SCSIDevice directly
2019-05-02 15:55 [Qemu-devel] [PATCH] s390/ipl: cast to SCSIDevice directly Cornelia Huck
` (2 preceding siblings ...)
2019-05-02 16:10 ` Philippe Mathieu-Daudé
@ 2019-05-02 17:49 ` Christian Borntraeger
2019-05-02 17:49 ` Christian Borntraeger
2019-05-03 8:09 ` Cornelia Huck
4 siblings, 1 reply; 10+ messages in thread
From: Christian Borntraeger @ 2019-05-02 17:49 UTC (permalink / raw)
To: Cornelia Huck, Thomas Huth; +Cc: qemu-s390x, qemu-devel, Jason J . Herne
On 02.05.19 17:55, Cornelia Huck wrote:
> Coverity notes that the result of object_dynamic_cast() to
> SCSIDevice is not checked in s390_gen_initial_iplp(); as
> we know that we always have a SCSIDevice in that branch,
> we can instead cast via SCSI_DEVICE directly.
>
And it even does look nicer.
Reviewed-by: Christian Borntraeger <borntraeger@de.ibm.com>
> Coverity: CID 1401098
> Fixes: 44445d8668f4 ("s390 vfio-ccw: Add bootindex property and IPLB data")
> Signed-off-by: Cornelia Huck <cohuck@redhat.com>
> ---
> hw/s390x/ipl.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c
> index d0cc06a05fd0..b93750c14eac 100644
> --- a/hw/s390x/ipl.c
> +++ b/hw/s390x/ipl.c
> @@ -374,8 +374,7 @@ static bool s390_gen_initial_iplb(S390IPLState *ipl)
> if (ccw_dev) {
> switch (devtype) {
> case CCW_DEVTYPE_SCSI:
> - sd = (SCSIDevice *) object_dynamic_cast(OBJECT(dev_st),
> - TYPE_SCSI_DEVICE);
> + sd = SCSI_DEVICE(dev_st);
> ipl->iplb.len = cpu_to_be32(S390_IPLB_MIN_QEMU_SCSI_LEN);
> ipl->iplb.blk0_len =
> cpu_to_be32(S390_IPLB_MIN_QEMU_SCSI_LEN - S390_IPLB_HEADER_LEN);
>
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [Qemu-devel] [PATCH] s390/ipl: cast to SCSIDevice directly
2019-05-02 17:49 ` Christian Borntraeger
@ 2019-05-02 17:49 ` Christian Borntraeger
0 siblings, 0 replies; 10+ messages in thread
From: Christian Borntraeger @ 2019-05-02 17:49 UTC (permalink / raw)
To: Cornelia Huck, Thomas Huth; +Cc: Jason J . Herne, qemu-s390x, qemu-devel
On 02.05.19 17:55, Cornelia Huck wrote:
> Coverity notes that the result of object_dynamic_cast() to
> SCSIDevice is not checked in s390_gen_initial_iplp(); as
> we know that we always have a SCSIDevice in that branch,
> we can instead cast via SCSI_DEVICE directly.
>
And it even does look nicer.
Reviewed-by: Christian Borntraeger <borntraeger@de.ibm.com>
> Coverity: CID 1401098
> Fixes: 44445d8668f4 ("s390 vfio-ccw: Add bootindex property and IPLB data")
> Signed-off-by: Cornelia Huck <cohuck@redhat.com>
> ---
> hw/s390x/ipl.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c
> index d0cc06a05fd0..b93750c14eac 100644
> --- a/hw/s390x/ipl.c
> +++ b/hw/s390x/ipl.c
> @@ -374,8 +374,7 @@ static bool s390_gen_initial_iplb(S390IPLState *ipl)
> if (ccw_dev) {
> switch (devtype) {
> case CCW_DEVTYPE_SCSI:
> - sd = (SCSIDevice *) object_dynamic_cast(OBJECT(dev_st),
> - TYPE_SCSI_DEVICE);
> + sd = SCSI_DEVICE(dev_st);
> ipl->iplb.len = cpu_to_be32(S390_IPLB_MIN_QEMU_SCSI_LEN);
> ipl->iplb.blk0_len =
> cpu_to_be32(S390_IPLB_MIN_QEMU_SCSI_LEN - S390_IPLB_HEADER_LEN);
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Qemu-devel] [PATCH] s390/ipl: cast to SCSIDevice directly
2019-05-02 15:55 [Qemu-devel] [PATCH] s390/ipl: cast to SCSIDevice directly Cornelia Huck
` (3 preceding siblings ...)
2019-05-02 17:49 ` Christian Borntraeger
@ 2019-05-03 8:09 ` Cornelia Huck
2019-05-03 8:09 ` Cornelia Huck
4 siblings, 1 reply; 10+ messages in thread
From: Cornelia Huck @ 2019-05-03 8:09 UTC (permalink / raw)
To: Thomas Huth, Christian Borntraeger
Cc: qemu-s390x, qemu-devel, Jason J . Herne
On Thu, 2 May 2019 17:55:16 +0200
Cornelia Huck <cohuck@redhat.com> wrote:
> Coverity notes that the result of object_dynamic_cast() to
> SCSIDevice is not checked in s390_gen_initial_iplp(); as
> we know that we always have a SCSIDevice in that branch,
> we can instead cast via SCSI_DEVICE directly.
>
> Coverity: CID 1401098
> Fixes: 44445d8668f4 ("s390 vfio-ccw: Add bootindex property and IPLB data")
> Signed-off-by: Cornelia Huck <cohuck@redhat.com>
> ---
> hw/s390x/ipl.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Queued to s390-next.
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [Qemu-devel] [PATCH] s390/ipl: cast to SCSIDevice directly
2019-05-03 8:09 ` Cornelia Huck
@ 2019-05-03 8:09 ` Cornelia Huck
0 siblings, 0 replies; 10+ messages in thread
From: Cornelia Huck @ 2019-05-03 8:09 UTC (permalink / raw)
To: Thomas Huth, Christian Borntraeger
Cc: Jason J . Herne, qemu-s390x, qemu-devel
On Thu, 2 May 2019 17:55:16 +0200
Cornelia Huck <cohuck@redhat.com> wrote:
> Coverity notes that the result of object_dynamic_cast() to
> SCSIDevice is not checked in s390_gen_initial_iplp(); as
> we know that we always have a SCSIDevice in that branch,
> we can instead cast via SCSI_DEVICE directly.
>
> Coverity: CID 1401098
> Fixes: 44445d8668f4 ("s390 vfio-ccw: Add bootindex property and IPLB data")
> Signed-off-by: Cornelia Huck <cohuck@redhat.com>
> ---
> hw/s390x/ipl.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Queued to s390-next.
^ permalink raw reply [flat|nested] 10+ messages in thread