From: Thomas Huth <thuth@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: "Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Beraldo Leal" <bleal@redhat.com>,
"Eduardo Lima" <elima@redhat.com>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH 2/2] gitlab: run all jobs with QOM debugging enabled
Date: Fri, 21 Apr 2023 14:54:13 +0200 [thread overview]
Message-ID: <40bff0e4-3801-7292-0445-1518bae22574@redhat.com> (raw)
In-Reply-To: <20230421124142.2640825-3-berrange@redhat.com>
On 21/04/2023 14.41, Daniel P. Berrangé wrote:
> The QMO cast debugging is designed to catch developer mistakes
> and as such should always be enabled during CI runs.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
> .gitlab-ci.d/buildtest-template.yml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/.gitlab-ci.d/buildtest-template.yml b/.gitlab-ci.d/buildtest-template.yml
> index a6cfe9be97..9151dece6f 100644
> --- a/.gitlab-ci.d/buildtest-template.yml
> +++ b/.gitlab-ci.d/buildtest-template.yml
> @@ -12,6 +12,7 @@
> - mkdir build
> - cd build
> - ../configure --enable-werror --disable-docs --enable-fdt=system
> + --enable-qom-cast-debug
> ${LD_JOBS:+--meson=git} ${TARGETS:+--target-list="$TARGETS"}
> $CONFIGURE_ARGS ||
> { cat config.log meson-logs/meson-log.txt && exit 1; }
No, it's better to always enable it again, since it was just switched off by
accident in the past:
https://lore.kernel.org/qemu-devel/20230417130037.236747-3-thuth@redhat.com/
Thomas
next prev parent reply other threads:[~2023-04-21 12:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-21 12:41 [PATCH 0/2] fix broken pxb-cxl realization Daniel P. Berrangé
2023-04-21 12:41 ` [PATCH 1/2] hw/pci-bridge: fix cast for pxb-cxl dev realization Daniel P. Berrangé
2023-04-21 12:47 ` Thomas Huth
2023-04-21 12:41 ` [PATCH 2/2] gitlab: run all jobs with QOM debugging enabled Daniel P. Berrangé
2023-04-21 12:54 ` Thomas Huth [this message]
2023-04-21 13:03 ` [PATCH 0/2] fix broken pxb-cxl realization Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40bff0e4-3801-7292-0445-1518bae22574@redhat.com \
--to=thuth@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=bleal@redhat.com \
--cc=elima@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).