From: Ninad Palsule <ninad@linux.ibm.com>
To: "Cédric Le Goater" <clg@kaod.org>,
qemu-devel@nongnu.org, peter.maydell@linaro.org, andrew@aj.id.au,
joel@jms.id.au, pbonzini@redhat.com, marcandre.lureau@redhat.com,
berrange@redhat.com, thuth@redhat.com, philmd@linaro.org,
lvivier@redhat.com
Cc: qemu-arm@nongnu.org
Subject: Re: [PATCH v5 00/10] Introduce model for IBM's FSI
Date: Sat, 21 Oct 2023 15:45:25 -0500 [thread overview]
Message-ID: <40c94d54-cb2b-48f4-b62d-8133dbe1a689@linux.ibm.com> (raw)
In-Reply-To: <cd99c52d-8232-4598-83cf-088a715a7a34@kaod.org>
Hello Cedric,
On 10/19/23 03:16, Cédric Le Goater wrote:
> Hello Ninad,
>
>
> On 10/11/23 17:13, Ninad Palsule wrote:
>> Hello,
>>
>> Please review the patch-set version 5.
>> I have incorporated review comments from Cedric.
>>
>> Ninad Palsule (10):
>> hw/fsi: Introduce IBM's Local bus
>> hw/fsi: Introduce IBM's scratchpad
>> hw/fsi: Introduce IBM's cfam,fsi-slave
>> hw/fsi: Introduce IBM's FSI
>> hw/fsi: IBM's On-chip Peripheral Bus
>> hw/fsi: Aspeed APB2OPB interface
>> hw/arm: Hook up FSI module in AST2600
>> hw/fsi: Added qtest
>> hw/fsi: Added FSI documentation
>> hw/fsi: Update MAINTAINER list
>
> I made some comments, mostly on the bus models which need to be reworked.
> This is code reshuffling and it should simplify the models. Please
> consider
> reducing the amount of files.
I have incorporated most of your comments but couldn't reduce the files
as there is a file per bus or device.
>
> Also, could please remove my Sob ? I didn't write any of this, only did
> quick fixes over the years because I kept the series in my aspeed tree.
> And this would help me to add a Rb :)
Removed your name from signed off by.
>
> I expect one or two respins before merge. 8.2 freeze window is in less
> than 3 weeks. It could make it, else the next. No big issue since I think
> we have been dragging these models for at least 5/6 years.
I am hoping to get it in 8.2
Thanks for the review.
Regards,
Ninad
>
> Thanks,
>
> C.
>
>
>>
>> MAINTAINERS | 8 +
>> docs/specs/fsi.rst | 141 ++++++++++++
>> meson.build | 1 +
>> hw/fsi/trace.h | 1 +
>> include/hw/arm/aspeed_soc.h | 4 +
>> include/hw/fsi/aspeed-apb2opb.h | 33 +++
>> include/hw/fsi/cfam.h | 58 +++++
>> include/hw/fsi/engine-scratchpad.h | 33 +++
>> include/hw/fsi/fsi-master.h | 30 +++
>> include/hw/fsi/fsi-slave.h | 29 +++
>> include/hw/fsi/fsi.h | 37 +++
>> include/hw/fsi/lbus.h | 51 +++++
>> include/hw/fsi/opb.h | 43 ++++
>> include/qemu/bitops.h | 6 +
>> hw/arm/aspeed_ast2600.c | 19 ++
>> hw/fsi/aspeed-apb2opb.c | 350 +++++++++++++++++++++++++++++
>> hw/fsi/cfam.c | 220 ++++++++++++++++++
>> hw/fsi/engine-scratchpad.c | 99 ++++++++
>> hw/fsi/fsi-master.c | 198 ++++++++++++++++
>> hw/fsi/fsi-slave.c | 96 ++++++++
>> hw/fsi/fsi.c | 54 +++++
>> hw/fsi/lbus.c | 87 +++++++
>> hw/fsi/opb.c | 185 +++++++++++++++
>> tests/qtest/fsi-test.c | 210 +++++++++++++++++
>> hw/Kconfig | 1 +
>> hw/arm/Kconfig | 1 +
>> hw/fsi/Kconfig | 23 ++
>> hw/fsi/meson.build | 6 +
>> hw/fsi/trace-events | 15 ++
>> hw/meson.build | 1 +
>> tests/qtest/meson.build | 2 +
>> 31 files changed, 2042 insertions(+)
>> create mode 100644 docs/specs/fsi.rst
>> create mode 100644 hw/fsi/trace.h
>> create mode 100644 include/hw/fsi/aspeed-apb2opb.h
>> create mode 100644 include/hw/fsi/cfam.h
>> create mode 100644 include/hw/fsi/engine-scratchpad.h
>> create mode 100644 include/hw/fsi/fsi-master.h
>> create mode 100644 include/hw/fsi/fsi-slave.h
>> create mode 100644 include/hw/fsi/fsi.h
>> create mode 100644 include/hw/fsi/lbus.h
>> create mode 100644 include/hw/fsi/opb.h
>> create mode 100644 hw/fsi/aspeed-apb2opb.c
>> create mode 100644 hw/fsi/cfam.c
>> create mode 100644 hw/fsi/engine-scratchpad.c
>> create mode 100644 hw/fsi/fsi-master.c
>> create mode 100644 hw/fsi/fsi-slave.c
>> create mode 100644 hw/fsi/fsi.c
>> create mode 100644 hw/fsi/lbus.c
>> create mode 100644 hw/fsi/opb.c
>> create mode 100644 tests/qtest/fsi-test.c
>> create mode 100644 hw/fsi/Kconfig
>> create mode 100644 hw/fsi/meson.build
>> create mode 100644 hw/fsi/trace-events
>>
>
prev parent reply other threads:[~2023-10-21 20:46 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-11 15:13 [PATCH v5 00/10] Introduce model for IBM's FSI Ninad Palsule
2023-10-11 15:13 ` [PATCH v5 01/10] hw/fsi: Introduce IBM's Local bus Ninad Palsule
2023-10-19 8:03 ` Cédric Le Goater
2023-10-21 20:20 ` Ninad Palsule
2023-10-19 8:08 ` Cédric Le Goater
2023-10-21 20:21 ` Ninad Palsule
2023-10-19 8:14 ` Daniel P. Berrangé
2023-10-19 15:34 ` Ninad Palsule
2023-10-19 16:09 ` Daniel P. Berrangé
2023-10-21 20:22 ` Ninad Palsule
2023-10-11 15:13 ` [PATCH v5 02/10] hw/fsi: Introduce IBM's scratchpad Ninad Palsule
2023-10-19 8:20 ` Daniel P. Berrangé
2023-10-21 20:27 ` Ninad Palsule
2023-10-11 15:13 ` [PATCH v5 03/10] hw/fsi: Introduce IBM's cfam,fsi-slave Ninad Palsule
2023-10-19 8:00 ` Cédric Le Goater
2023-10-21 20:33 ` Ninad Palsule
2023-10-19 8:26 ` Daniel P. Berrangé
2023-10-21 20:34 ` Ninad Palsule
2023-10-19 17:28 ` Cédric Le Goater
2023-10-21 20:35 ` Ninad Palsule
2023-10-11 15:13 ` [PATCH v5 04/10] hw/fsi: Introduce IBM's FSI Ninad Palsule
2023-10-19 7:44 ` Cédric Le Goater
2023-10-21 20:36 ` Ninad Palsule
2023-10-19 8:28 ` Daniel P. Berrangé
2023-10-21 20:37 ` Ninad Palsule
2023-10-11 15:13 ` [PATCH v5 05/10] hw/fsi: IBM's On-chip Peripheral Bus Ninad Palsule
2023-10-19 7:26 ` Cédric Le Goater
2023-10-21 20:40 ` Ninad Palsule
2023-10-19 8:30 ` Daniel P. Berrangé
2023-10-21 20:42 ` Ninad Palsule
2023-10-11 15:13 ` [PATCH v5 06/10] hw/fsi: Aspeed APB2OPB interface Ninad Palsule
2023-10-19 7:16 ` Cédric Le Goater
2023-10-21 20:43 ` Ninad Palsule
2023-10-11 15:13 ` [PATCH v5 07/10] hw/arm: Hook up FSI module in AST2600 Ninad Palsule
2023-10-11 15:13 ` [PATCH v5 08/10] hw/fsi: Added qtest Ninad Palsule
2023-10-11 15:35 ` Thomas Huth
2023-10-11 16:54 ` Ninad Palsule
2023-10-11 15:13 ` [PATCH v5 09/10] hw/fsi: Added FSI documentation Ninad Palsule
2023-10-11 15:13 ` [PATCH v5 10/10] hw/fsi: Update MAINTAINER list Ninad Palsule
2023-10-19 8:16 ` [PATCH v5 00/10] Introduce model for IBM's FSI Cédric Le Goater
2023-10-21 20:45 ` Ninad Palsule [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40c94d54-cb2b-48f4-b62d-8133dbe1a689@linux.ibm.com \
--to=ninad@linux.ibm.com \
--cc=andrew@aj.id.au \
--cc=berrange@redhat.com \
--cc=clg@kaod.org \
--cc=joel@jms.id.au \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).