From: Richard Henderson <richard.henderson@linaro.org>
To: Daniel Henrique Barboza <dbarboza@ventanamicro.com>,
qemu-devel@nongnu.org
Cc: qemu-riscv@nongnu.org, alistair.francis@wdc.com,
bmeng@tinylab.org, liweiwei@iscas.ac.cn,
zhiwei_liu@linux.alibaba.com, palmer@rivosinc.com
Subject: Re: [PATCH v7 07/12] target/riscv/cpu.c: add ADD_CPU_QDEV_PROPERTIES_ARRAY() macro
Date: Tue, 15 Aug 2023 13:44:14 -0700 [thread overview]
Message-ID: <40ec95c2-7775-4a40-f73a-8f92d3cfb00c@linaro.org> (raw)
In-Reply-To: <20230815201559.398643-8-dbarboza@ventanamicro.com>
On 8/15/23 13:15, Daniel Henrique Barboza wrote:
> @@ -1883,6 +1883,13 @@ static void cpu_set_cfg_unavailable(Object *obj, Visitor *v,
> }
> #endif
>
> +#define ADD_CPU_QDEV_PROPERTIES_ARRAY(_dev, _array) \
> + do { \
> + for (Property *prop = _array; prop && prop->name; prop++) { \
> + qdev_property_add_static(_dev, prop); \
> + } \
> + } while (0)
Any reason not to make this a proper function?
r~
next prev parent reply other threads:[~2023-08-15 20:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-15 20:15 [PATCH v7 00/12] riscv: add 'max' CPU, deprecate 'any' Daniel Henrique Barboza
2023-08-15 20:15 ` [PATCH v7 01/12] target/riscv/cpu.c: split CPU options from riscv_cpu_extensions[] Daniel Henrique Barboza
2023-08-15 20:15 ` [PATCH v7 02/12] target/riscv/cpu.c: skip 'bool' check when filtering KVM props Daniel Henrique Barboza
2023-08-15 20:15 ` [PATCH v7 03/12] target/riscv/cpu.c: split kvm prop handling to its own helper Daniel Henrique Barboza
2023-08-15 20:15 ` [PATCH v7 04/12] target/riscv: add DEFINE_PROP_END_OF_LIST() to riscv_cpu_options[] Daniel Henrique Barboza
2023-08-15 20:15 ` [PATCH v7 05/12] target/riscv/cpu.c: split vendor exts from riscv_cpu_extensions[] Daniel Henrique Barboza
2023-08-15 20:15 ` [PATCH v7 06/12] target/riscv/cpu.c: split non-ratified " Daniel Henrique Barboza
2023-08-15 20:15 ` [PATCH v7 07/12] target/riscv/cpu.c: add ADD_CPU_QDEV_PROPERTIES_ARRAY() macro Daniel Henrique Barboza
2023-08-15 20:44 ` Richard Henderson [this message]
2023-08-15 21:15 ` Daniel Henrique Barboza
2023-08-15 22:02 ` Richard Henderson
2023-08-15 20:15 ` [PATCH v7 08/12] target/riscv/cpu.c: add ADD_UNAVAIL_KVM_PROP_ARRAY() macro Daniel Henrique Barboza
2023-08-15 20:15 ` [PATCH v7 09/12] target/riscv/cpu.c: limit cfg->vext_spec log message Daniel Henrique Barboza
2023-08-15 20:15 ` [PATCH v7 10/12] target/riscv: add 'max' CPU type Daniel Henrique Barboza
2023-08-15 20:15 ` [PATCH v7 11/12] avocado, risc-v: add opensbi tests for 'max' CPU Daniel Henrique Barboza
2023-08-15 20:15 ` [PATCH v7 12/12] target/riscv: deprecate the 'any' CPU type Daniel Henrique Barboza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40ec95c2-7775-4a40-f73a-8f92d3cfb00c@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alistair.francis@wdc.com \
--cc=bmeng@tinylab.org \
--cc=dbarboza@ventanamicro.com \
--cc=liweiwei@iscas.ac.cn \
--cc=palmer@rivosinc.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=zhiwei_liu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).