From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4531BC433E1 for ; Fri, 10 Jul 2020 14:45:36 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 17AC1206A1 for ; Fri, 10 Jul 2020 14:45:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 17AC1206A1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:60056 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jtuHP-0007bB-A2 for qemu-devel@archiver.kernel.org; Fri, 10 Jul 2020 10:45:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46014) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jtuGD-0006gs-5Q for qemu-devel@nongnu.org; Fri, 10 Jul 2020 10:44:21 -0400 Received: from mx2.suse.de ([195.135.220.15]:50272) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jtuGB-0006wM-AH for qemu-devel@nongnu.org; Fri, 10 Jul 2020 10:44:20 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 4FF34AC24; Fri, 10 Jul 2020 14:44:17 +0000 (UTC) Subject: Re: [PULL v2 00/52] Misc patches for QEMU 5.1 soft freeze To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Peter Maydell References: <20200708172542.25012-1-pbonzini@redhat.com> <9631042d-00e4-2a2e-292b-66ca1b590120@suse.de> From: Claudio Fontana Message-ID: <40f4c566-8a5b-c27e-22a7-2a112a0cd77d@suse.de> Date: Fri, 10 Jul 2020 16:44:16 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=195.135.220.15; envelope-from=cfontana@suse.de; helo=mx2.suse.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/10 00:07:08 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x (no timestamps) [generic] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , QEMU Developers , Max Reitz Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 7/10/20 3:11 PM, Philippe Mathieu-Daudé wrote: > On 7/10/20 2:55 PM, Peter Maydell wrote: >> On Fri, 10 Jul 2020 at 13:52, Claudio Fontana wrote: >>> If you can access it, >>> >>> https://cirrus-ci.com/task/5537514263937024?command=main#L2039 >>> >>> the thing is treated here as a warning, which is in the middle of a large amount of other warnings. >>> >>> private/var/folders/3y/l0z1x3693dl_8n0qybp4dqwh0000gn/T/cirrus-ci-build/ui/vnc-auth-sasl.c:648:29: warning: 'sasl_errdetail' is deprecated: first deprecated in macOS 10.11 [-Wdeprecated-declarations] >>> sasl_errdetail(vs->sasl.conn)); >>> >>> /* ... lots of similar warnings */ >>> >>> private/var/folders/3y/l0z1x3693dl_8n0qybp4dqwh0000gn/T/cirrus-ci-build/ui/cocoa.m:1478:9: warning: implicit declaration of function 'cpu_throttle_set' is invalid in C99 [-Wimplicit-function-declaration] >>> cpu_throttle_set(throttle_pct); >>> ^ >>> >>> >>> Apparently the cirrus-ci I am using is not treating this as an error, while what you are using is.. >> >> Ah, I see. Yeah, configure by default doesn't enable -Werror for OSX. >> My build tree has >> '--extra-cflags=-fdiagnostics-color=never -Werror >> -Wno-error=deprecated-declarations' > > TIL this is different on OSX... > >> >> (of which the last two are relevant here). We should probably >> make configure use -Werror on OSX now with the same logic as Linux, >> I've been using it that way for ages without issues. > > Yes please! > Speaking of MacOS and CI, commit 57ee95ed4ee7b4c039ec5f0705c45734c56706bc Author: Max Reitz Date: Thu Jun 25 14:55:30 2020 +0200 iotests: Make _filter_img_create more active broke cirrus-ci completely for me due to missing "readarray" builtin. Maybe it is bash vs zsh? Ciao, Claudio