From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1C2vDd-0007U0-2Z for qemu-devel@nongnu.org; Thu, 02 Sep 2004 13:17:53 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1C2vDb-0007TW-Ef for qemu-devel@nongnu.org; Thu, 02 Sep 2004 13:17:52 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1C2vDb-0007TL-9w for qemu-devel@nongnu.org; Thu, 02 Sep 2004 13:17:51 -0400 Received: from [129.104.30.34] (helo=a.mx.polytechnique.org) by monty-python.gnu.org with esmtp (Exim 4.34) id 1C2v86-0002Rw-Cd for qemu-devel@nongnu.org; Thu, 02 Sep 2004 13:12:10 -0400 Received: from localhost (localhost [127.0.0.1]) by djali.m4x.org (Postfix) with ESMTP id B1EA2331C3 for ; Thu, 2 Sep 2004 19:12:09 +0200 (CEST) Received: from djali.m4x.org ([127.0.0.1]) by localhost (djali [127.0.0.1]) (amavisd-new, port 10025) with ESMTP id 05826-07 for ; Thu, 2 Sep 2004 19:12:09 +0200 (CEST) Received: from [172.17.17.9] (gw.netgem.com [195.68.2.34]) (using TLSv1 with cipher RC4-MD5 (128/128 bits)) (No client certificate requested) by ssl.polytechnique.org (Postfix) with ESMTP id 7FA8B33191 for ; Thu, 2 Sep 2004 19:12:09 +0200 (CEST) Message-ID: <41375469.9050508@bellard.org> Date: Thu, 02 Sep 2004 19:12:09 +0200 From: Fabrice Bellard MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] DOSEMU image file support References: <20040902171512.61266d0e.hampa@hampa.ch> <4137454D.8080202@bellard.org> <20040902190014.33359ecd.hampa@hampa.ch> In-Reply-To: <20040902190014.33359ecd.hampa@hampa.ch> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Hampa Hug wrote: > Fabrice Bellard wrote: > > >>Thank you for the patch. Two remarks if you want that I merge it: >> >>1) use open/read/write/close instead of fopen/fread/fwrite/fclose for >>consistency with other block drivers. > > > The reason I used stdio is that read/write are non-blocking. It is > not an error for read to return fewer bytes than requested. If that > happens, the other block drivers fail. I agree, but for disk accesses it is usual to assume they return the requested amount of bytes. fread/fwrite are buffered I/Os which is a bit overkill for block drivers. >>2) change the license to BSD > > > I was under the impression that we used GPL. At least that's what > COPYING says. The different parts of QEMU have different licenses (and of course it affects the license of the resulting program). As mentionned on the web page: - The QEMU virtual CPU core library is released under the GNU Lesser General Public License. - The Linux QEMU emulator is released under the GNU General Public License. - The QEMU PC system emulator is released under the MIT/BSD License. The block layer belongs to the QEMU PC system emulator, so its license is BSD. Fabrice.