From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Konstantin Kostiuk <kkostiuk@redhat.com>, qemu-devel@nongnu.org
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Michael Roth" <michael.roth@amd.com>,
"Yan Vugenfirer" <yvugenfi@redhat.com>
Subject: Re: [PATCH 1/4] QGA VSS: Add wrapper to send log to debugger and stderr
Date: Wed, 5 Jul 2023 22:35:07 +0200 [thread overview]
Message-ID: <413a30a2-c050-7587-8c0e-a6d89c8b7ab3@linaro.org> (raw)
In-Reply-To: <20230705141205.525776-2-kkostiuk@redhat.com>
Hi Konstantin,
On 5/7/23 16:12, Konstantin Kostiuk wrote:
> Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com>
> ---
> qga/vss-win32/vss-debug.h | 31 +++++++++++++++++++++++++++++++
> 1 file changed, 31 insertions(+)
> create mode 100644 qga/vss-win32/vss-debug.h
> +#define PRINT_DEBUG(fmt, ...) { \
> + char user_sting[512] = { 0 }; \
> + char full_string[640] = { 0 }; \
> + snprintf(user_sting, 512, fmt, ## __VA_ARGS__); \
> + snprintf(full_string, 640, QGA_PROVIDER_NAME"[%lu]: %s %s\n", \
> + GetCurrentThreadId(), __func__, user_sting); \
> + OutputDebugString(full_string); \
> + fprintf(stderr, "%s", full_string); \
> +}
Why not simply use a plain function?
> +#define PRINT_DEBUG_BEGIN PRINT_DEBUG("begin")
> +#define PRINT_DEBUG_END PRINT_DEBUG("end")
> +
> +#endif
next prev parent reply other threads:[~2023-07-05 20:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-05 14:12 [PATCH 0/4] QGA VSS Logging Konstantin Kostiuk
2023-07-05 14:12 ` [PATCH 1/4] QGA VSS: Add wrapper to send log to debugger and stderr Konstantin Kostiuk
2023-07-05 20:35 ` Philippe Mathieu-Daudé [this message]
2023-07-06 7:54 ` Konstantin Kostiuk
2023-07-06 10:01 ` Philippe Mathieu-Daudé
2023-07-06 10:58 ` Konstantin Kostiuk
2023-07-06 16:48 ` Philippe Mathieu-Daudé
2023-07-05 14:12 ` [PATCH 2/4] QGA VSS: Replace 'fprintf(stderr' with PRINT_DEBUG Konstantin Kostiuk
2023-07-05 20:36 ` Philippe Mathieu-Daudé
2023-07-06 8:36 ` Konstantin Kostiuk
2023-07-05 14:12 ` [PATCH 3/4] QGA VSS: Print error in err_set Konstantin Kostiuk
2023-07-05 14:12 ` [PATCH 4/4] QGA VSS: Add log in functions begin/end Konstantin Kostiuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=413a30a2-c050-7587-8c0e-a6d89c8b7ab3@linaro.org \
--to=philmd@linaro.org \
--cc=kkostiuk@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=michael.roth@amd.com \
--cc=qemu-devel@nongnu.org \
--cc=yvugenfi@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).