From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1C5lMX-0004jG-GI for qemu-devel@nongnu.org; Fri, 10 Sep 2004 09:22:49 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1C5lMV-0004j4-RT for qemu-devel@nongnu.org; Fri, 10 Sep 2004 09:22:49 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1C5lMV-0004j1-Og for qemu-devel@nongnu.org; Fri, 10 Sep 2004 09:22:47 -0400 Received: from [129.104.30.34] (helo=a.mx.polytechnique.org) by monty-python.gnu.org with esmtp (Exim 4.34) id 1C5lH0-0004gi-Sc for qemu-devel@nongnu.org; Fri, 10 Sep 2004 09:17:07 -0400 Received: from localhost (localhost [127.0.0.1]) by djali.m4x.org (Postfix) with ESMTP id 258383323C for ; Fri, 10 Sep 2004 15:17:05 +0200 (CEST) Received: from djali.m4x.org ([127.0.0.1]) by localhost (djali [127.0.0.1]) (amavisd-new, port 10025) with ESMTP id 23769-08 for ; Fri, 10 Sep 2004 15:17:05 +0200 (CEST) Received: from [172.17.17.9] (gw.netgem.com [195.68.2.34]) (using TLSv1 with cipher RC4-MD5 (128/128 bits)) (No client certificate requested) by ssl.polytechnique.org (Postfix) with ESMTP id A5F2433236 for ; Fri, 10 Sep 2004 15:17:04 +0200 (CEST) Message-ID: <4141A950.2010100@bellard.org> Date: Fri, 10 Sep 2004 15:17:04 +0200 From: Fabrice Bellard MIME-Version: 1.0 Subject: Re: [Qemu-devel] [patch] incorrect VGA initialization, can provide image References: <20040910122612.45544.qmail@web52503.mail.yahoo.com> In-Reply-To: <20040910122612.45544.qmail@web52503.mail.yahoo.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org OK for the idea, but it is not acceptable to slow down the VGA write functions just to detect the font change. Another solution must be found. Fabrice. Piotr Krysik wrote: > Hi, > > Thanks for your comment. > > I updated the patch to factor common code from > vga_mem_writeb and remove goto. The source should > be easer to read now. > > > Regards, > > Piotrek > > --- Johannes Schindelin > wrote: > > >>Hi, >> >>why not consolidate those identical lines (checking >>if the address is in >>font memory) into a function? >> >>Just a thought, >>Dscho > > > > > > __________________________________ > Do you Yahoo!? > New and Improved Yahoo! Mail - 100MB free storage! > http://promotions.yahoo.com/new_mail > > > ------------------------------------------------------------------------ > > _______________________________________________ > Qemu-devel mailing list > Qemu-devel@nongnu.org > http://lists.nongnu.org/mailman/listinfo/qemu-devel