From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1CCm0S-0006Zp-9n for qemu-devel@nongnu.org; Wed, 29 Sep 2004 17:29:00 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CCm0R-0006ZU-Po for qemu-devel@nongnu.org; Wed, 29 Sep 2004 17:28:59 -0400 Received: from [129.104.30.34] (helo=a.mx.polytechnique.org) by monty-python.gnu.org with esmtp (Exim 4.34) id 1CCltv-0001rH-JS for qemu-devel@nongnu.org; Wed, 29 Sep 2004 17:22:16 -0400 Received: from localhost (localhost [127.0.0.1]) by djali.polytechnique.org (Postfix) with ESMTP id 29CB133364 for ; Wed, 29 Sep 2004 23:22:16 +0200 (CEST) Received: from djali.polytechnique.org ([127.0.0.1]) by localhost (localhost [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 05354-03 for ; Wed, 29 Sep 2004 23:22:16 +0200 (CEST) Received: from bellard.org (nas-cbv-6-213-228-29-36.dial.proxad.net [213.228.29.36]) (using TLSv1 with cipher RC4-MD5 (128/128 bits)) (No client certificate requested) by ssl.polytechnique.org (Postfix) with ESMTP id CB28033193 for ; Wed, 29 Sep 2004 23:22:14 +0200 (CEST) Message-ID: <415B27B4.4070301@bellard.org> Date: Wed, 29 Sep 2004 23:23:00 +0200 From: Fabrice Bellard MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH] fix interaction with noexecstack References: <20040904000017.GA27986@xi.wantstofly.org> <41399DC2.2030404@bellard.org> <4139B2C3.6000203@volny.cz> <4139EA33.5020502@volny.cz> In-Reply-To: <4139EA33.5020502@volny.cz> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Applied with some modifications. Fabrice. Filip Navara wrote: > Ronald wrote: > >> Tested, need to include (and ). >> gcc juste produce a warning with VirtualProtect: >> /home/ronald/Prog/Win32/combo/qemu/exec.c: Dans la fonction « >> page_init »: >> /home/ronald/Prog/Win32/combo/qemu/exec.c:155: AVERTISSEMENT: passage de >> arg 1 de « VirtualProtect » transforme en pointeur un entier sans >> transtypage >> >> aproximative translation: in function page_init passing arg1 of >> VirtualProtect is making pointer from integer without a cast. >> >> > Thanks much for testing it, now I got a minute to test it on my box. The > attach patch adds the #include, fixes the warning and also dynamicly > detects the page size. These changes are actually needed when running > QEMU on WinXP SP2 on AMD64. I'm quite not happy with the (original) > patch yet, because it uses "unsigned long" for storing pointer and this > will *break any 64-bit build* on non-Windows platforms. It would be nice > if someone can solve it. > > (My only hope is that the MinGW build of QEMU will not be broken...) > > Regards, > Filip > >> Note: with **VirtualProtect or *VirtualProtect make is aborting, I have >> used VirtualProtect. >> >> > Sorry, my mail client messed that up