From: Eric Blake <eblake@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "QEMU Developers" <qemu-devel@nongnu.org>,
"Marc-André Lureau" <mlureau@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"patches@linaro.org" <patches@linaro.org>
Subject: Re: [Qemu-devel] [PATCH] Makefile: Put VERSION info into version.texi rather than using -D
Date: Fri, 17 Feb 2017 09:55:23 -0600 [thread overview]
Message-ID: <416f8017-31db-5833-f74e-67193880edb4@redhat.com> (raw)
In-Reply-To: <CAFEAcA8eNv0qRvULid3ungYGQXxvO3kN6uhBT07OFEHaL0864g@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 823 bytes --]
On 02/17/2017 09:52 AM, Peter Maydell wrote:
>>> Makefile | 17 ++++++++++-------
>>> docs/qemu-ga-ref.texi | 2 ++
>>> docs/qemu-qmp-ref.texi | 2 ++
>>> 3 files changed, 14 insertions(+), 7 deletions(-)
>>
>> Missing a change to .gitignore for version.texi.
>
> Should be
> --- a/.gitignore
> +++ b/.gitignore
> @@ -107,6 +107,7 @@ docs/qemu-ga-ref.info*
> docs/qemu-qmp-ref.info*
> /qemu-ga-qapi.texi
> /qemu-qapi.texi
> +/version.texi
> *.tps
> .stgit-*
> cscope.*
>
> right?
Yes, that looks right.
(Hmm - another file stuck in the top-level directory; a separate patch
might be worth sticking some of these generated .texi files under docs/
instead)
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
prev parent reply other threads:[~2017-02-17 15:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-17 15:12 [Qemu-devel] [PATCH] Makefile: Put VERSION info into version.texi rather than using -D Peter Maydell
2017-02-17 15:47 ` Marc-André Lureau
2017-02-17 15:50 ` Eric Blake
2017-02-17 15:52 ` Peter Maydell
2017-02-17 15:55 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=416f8017-31db-5833-f74e-67193880edb4@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=mlureau@redhat.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).