qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] hw/arm: Add missing ZynqMP ZCU102 -> USB_DWC3 Kconfig dependency
@ 2023-02-16  9:23 Philippe Mathieu-Daudé
  2023-02-16  9:27 ` Francisco Iglesias
  2023-02-16  9:27 ` Philippe Mathieu-Daudé
  0 siblings, 2 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-02-16  9:23 UTC (permalink / raw)
  To: qemu-devel, Francisco Iglesias
  Cc: qemu-arm, Edgar E. Iglesias, Alistair Francis, Peter Maydell,
	Thomas Huth, Philippe Mathieu-Daudé

Since commit acc0b8b05a when running the ZynqMP ZCU102 board with
a QEMU configured using --without-default-devices, we get:

  $ qemu-system-aarch64 -M xlnx-zcu102
  qemu-system-aarch64: missing object type 'usb_dwc3'
  Abort trap: 6

Fix by adding the missing Kconfig dependency.

Fixes: acc0b8b05a ("hw/arm/xlnx-zynqmp: Connect ZynqMP's USB controllers")
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 hw/arm/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig
index 2d157de9b8..b5aed4aff5 100644
--- a/hw/arm/Kconfig
+++ b/hw/arm/Kconfig
@@ -389,6 +389,7 @@ config XLNX_ZYNQMP_ARM
     select XLNX_CSU_DMA
     select XLNX_ZYNQMP
     select XLNX_ZDMA
+    select USB_DWC3
 
 config XLNX_VERSAL
     bool
-- 
2.38.1



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] hw/arm: Add missing ZynqMP ZCU102 -> USB_DWC3 Kconfig dependency
  2023-02-16  9:23 [PATCH] hw/arm: Add missing ZynqMP ZCU102 -> USB_DWC3 Kconfig dependency Philippe Mathieu-Daudé
@ 2023-02-16  9:27 ` Francisco Iglesias
  2023-02-16  9:27 ` Philippe Mathieu-Daudé
  1 sibling, 0 replies; 4+ messages in thread
From: Francisco Iglesias @ 2023-02-16  9:27 UTC (permalink / raw)
  To: Philippe Mathieu-Daudé, qemu-devel
  Cc: qemu-arm, Edgar E. Iglesias, Alistair Francis, Peter Maydell,
	Thomas Huth



On 2023-02-16 10:23, Philippe Mathieu-Daudé wrote:
> Since commit acc0b8b05a when running the ZynqMP ZCU102 board with
> a QEMU configured using --without-default-devices, we get:
> 
>    $ qemu-system-aarch64 -M xlnx-zcu102
>    qemu-system-aarch64: missing object type 'usb_dwc3'
>    Abort trap: 6
> 
> Fix by adding the missing Kconfig dependency.
> 
> Fixes: acc0b8b05a ("hw/arm/xlnx-zynqmp: Connect ZynqMP's USB controllers")
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Reviewed-by: Francisco Iglesias <francisco.iglesias@amd.com>

> ---
>   hw/arm/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig
> index 2d157de9b8..b5aed4aff5 100644
> --- a/hw/arm/Kconfig
> +++ b/hw/arm/Kconfig
> @@ -389,6 +389,7 @@ config XLNX_ZYNQMP_ARM
>       select XLNX_CSU_DMA
>       select XLNX_ZYNQMP
>       select XLNX_ZDMA
> +    select USB_DWC3
>   
>   config XLNX_VERSAL
>       bool


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] hw/arm: Add missing ZynqMP ZCU102 -> USB_DWC3 Kconfig dependency
  2023-02-16  9:23 [PATCH] hw/arm: Add missing ZynqMP ZCU102 -> USB_DWC3 Kconfig dependency Philippe Mathieu-Daudé
  2023-02-16  9:27 ` Francisco Iglesias
@ 2023-02-16  9:27 ` Philippe Mathieu-Daudé
  2023-02-16 11:38   ` Peter Maydell
  1 sibling, 1 reply; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-02-16  9:27 UTC (permalink / raw)
  To: qemu-devel, Francisco Iglesias
  Cc: qemu-arm, Edgar E. Iglesias, Alistair Francis, Peter Maydell,
	Thomas Huth

Oops I meant this as subject:
"hw/arm: Add missing XLNX_ZYNQMP_ARM -> USB_DWC3 Kconfig dependency"

On 16/2/23 10:23, Philippe Mathieu-Daudé wrote:
> Since commit acc0b8b05a when running the ZynqMP ZCU102 board with
> a QEMU configured using --without-default-devices, we get:
> 
>    $ qemu-system-aarch64 -M xlnx-zcu102
>    qemu-system-aarch64: missing object type 'usb_dwc3'
>    Abort trap: 6
> 
> Fix by adding the missing Kconfig dependency.
> 
> Fixes: acc0b8b05a ("hw/arm/xlnx-zynqmp: Connect ZynqMP's USB controllers")
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   hw/arm/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig
> index 2d157de9b8..b5aed4aff5 100644
> --- a/hw/arm/Kconfig
> +++ b/hw/arm/Kconfig
> @@ -389,6 +389,7 @@ config XLNX_ZYNQMP_ARM
>       select XLNX_CSU_DMA
>       select XLNX_ZYNQMP
>       select XLNX_ZDMA
> +    select USB_DWC3
>   
>   config XLNX_VERSAL
>       bool



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] hw/arm: Add missing ZynqMP ZCU102 -> USB_DWC3 Kconfig dependency
  2023-02-16  9:27 ` Philippe Mathieu-Daudé
@ 2023-02-16 11:38   ` Peter Maydell
  0 siblings, 0 replies; 4+ messages in thread
From: Peter Maydell @ 2023-02-16 11:38 UTC (permalink / raw)
  To: Philippe Mathieu-Daudé
  Cc: qemu-devel, Francisco Iglesias, qemu-arm, Edgar E. Iglesias,
	Alistair Francis, Thomas Huth

On Thu, 16 Feb 2023 at 09:27, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>
> Oops I meant this as subject:
> "hw/arm: Add missing XLNX_ZYNQMP_ARM -> USB_DWC3 Kconfig dependency"
>
> On 16/2/23 10:23, Philippe Mathieu-Daudé wrote:
> > Since commit acc0b8b05a when running the ZynqMP ZCU102 board with
> > a QEMU configured using --without-default-devices, we get:
> >
> >    $ qemu-system-aarch64 -M xlnx-zcu102
> >    qemu-system-aarch64: missing object type 'usb_dwc3'
> >    Abort trap: 6
> >
> > Fix by adding the missing Kconfig dependency.
> >
> > Fixes: acc0b8b05a ("hw/arm/xlnx-zynqmp: Connect ZynqMP's USB controllers")
> > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>



Applied to target-arm.next with the subject line fixed, thanks.

-- PMM


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-02-16 14:30 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-16  9:23 [PATCH] hw/arm: Add missing ZynqMP ZCU102 -> USB_DWC3 Kconfig dependency Philippe Mathieu-Daudé
2023-02-16  9:27 ` Francisco Iglesias
2023-02-16  9:27 ` Philippe Mathieu-Daudé
2023-02-16 11:38   ` Peter Maydell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).