Re: [Qemu-devel] [PATCH 00/10] hw/pci-host: Clean the GT64120 north bridge

["Philippe Mathieu-Daudé" <philmd@redhat.com>]

On 7/1/19 8:39 PM, Aleksandar Markovic wrote:
> On Jul 1, 2019 7:46 PM, "Philippe Mathieu-Daudé" <f4bug@amsat.org> wrote:
>>
>> Hi Aleksandar,
>>
>> On 7/1/19 7:16 PM, Aleksandar Markovic wrote:
>>>
>>> On Jun 25, 2019 12:31 AM, "Philippe Mathieu-Daudé" <f4bug@amsat.org
>>> <mailto:f4bug@amsat.org>> wrote:
>>>>
>>>> Hi,
>>>>
>>>> This series clean the gt64120 device.
>>>> It is no more target-dependent, and tracing is improved.
>>>>
>>>
>>> If nobody objects, I am going to select majority of the patches for mips
>>> queue scheduled tomorrow. Those that remain will be those that Philippe
>>> still didn't make his mind.
>>
>> Which ones remain?
>>
>> For "pci-host/gt64120: Clean the decoded address space", I'd like a
>> review from someone comfortable with MEMTXATTRS and address spaces.
>> I'll ping on the patch.
>>
> 
> Don't worry, the addres space one was left for later.
> 
> Sorry for confusion, but these patches are already in main tree (this is
> from today):
> 
> Philippe Mathieu-Daudé (7):
> 
> hw/mips/gt64xxx_pci: Fix multiline comment syntax
> 
> hw/mips/gt64xxx_pci: Fix 'tabs' coding style issues
> 
> hw/mips/gt64xxx_pci: Fix 'braces' coding style issues
> 
> hw/mips/gt64xxx_pci: Fix 'spaces' coding style issues
> 
> hw/mips/gt64xxx_pci: Use qemu_log_mask() instead of debug printf()
> 
> hw/mips/gt64xxx_pci: Convert debug printf()s to trace events
> 
> hw/mips/gt64xxx_pci: Align the pci0-mem size
> 
> Let me know if you want more for tomorrow, otherwise I won't do anything.

Excellent, thank you!

patch #8 "hw/mips/gt64xxx_pci: Add a 'cpu_big_endian' qdev property"
needs R-b (Thomas/Paolo eventually).

patch #9 depends of #8

I pinged Linux kernel people for patch #10.

Regards,

Phil.

> Amicalement,
> Aleksandar