qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Felipe Franciosi <felipe@nutanix.com>,
	Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>,
	"Daniel P. Berrange" <berrange@redhat.com>,
	Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 1/2] compiler: add ignore_value() macro
Date: Fri, 18 Nov 2016 15:09:18 -0600	[thread overview]
Message-ID: <419d6323-ab2f-5414-cfc9-4bc9a0433de1@redhat.com> (raw)
In-Reply-To: <B12E5518-4C6C-4B2D-A888-E71CA32BE367@nutanix.com>

[-- Attachment #1: Type: text/plain, Size: 1216 bytes --]

On 10/25/2016 10:21 AM, Felipe Franciosi wrote:
> 
>> On 12 Oct 2016, at 18:20, Felipe Franciosi <felipe@nutanix.com> wrote:
>>
>>
>>> On 21 Sep 2016, at 19:15, Eric Blake <eblake@redhat.com> wrote:
>>>
>>> On 09/21/2016 10:27 AM, Felipe Franciosi wrote:
>>>> On GCC versions 3.4 and newer, simply using (void) in front of a
>>>> function that has been declared with WUR will no longer suppress a
>>>> compilation warning. This commit brings the ignore_value() macro from
>>>> GNULIB's ignore_value.h, licensed under the terms of LGPLv2+.
>>>>
>>>> See the link below for the original author's comment:
>>>> https://lists.nongnu.org/archive/html/qemu-devel/2016-09/msg05148.html
>>>>
>>>> Signed-off-by: Felipe Franciosi <felipe@nutanix.com>
>>>> ---
>>>> include/qemu/compiler.h | 8 ++++++++
>>>> 1 file changed, 8 insertions(+)
>>>
>>> Reviewed-by: Eric Blake <eblake@redhat.com>
>>>

> 
> Ping?

It's missed 2.8, but I still think it is a useful patch; I just
commented on another thread about a case where a cast-to-void might look
better with the use of ignore_value().

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

      reply	other threads:[~2016-11-18 21:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-21 15:27 [Qemu-devel] [PATCH 1/2] compiler: add ignore_value() macro Felipe Franciosi
2016-09-21 15:27 ` [Qemu-devel] [PATCH 2/2] replay: Ignore the return value of fwrite() Felipe Franciosi
2016-09-21 18:17   ` Eric Blake
2016-09-21 18:43     ` Felipe Franciosi
2016-09-21 18:15 ` [Qemu-devel] [PATCH 1/2] compiler: add ignore_value() macro Eric Blake
2016-10-12 17:20   ` Felipe Franciosi
2016-10-25 15:21     ` Felipe Franciosi
2016-11-18 21:09       ` Eric Blake [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=419d6323-ab2f-5414-cfc9-4bc9a0433de1@redhat.com \
    --to=eblake@redhat.com \
    --cc=Pavel.Dovgaluk@ispras.ru \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=felipe@nutanix.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).