* [Qemu-devel] [PATCH] parallel and -nographic
@ 2005-01-15 19:23 Magnus Damm
2005-01-15 20:20 ` Fabrice Bellard
0 siblings, 1 reply; 3+ messages in thread
From: Magnus Damm @ 2005-01-15 19:23 UTC (permalink / raw)
To: qemu-devel; +Cc: Magnus Damm
Hello,
The recent parallel port change broke -nographic. Without this patch
"qemu -nographic" fails and outputs the following error:
qemu: could not open parallel device 'stdio'
/ magnus
Index: vl.c
===================================================================
RCS file: /cvsroot/qemu/qemu/vl.c,v
retrieving revision 1.116
diff -u -r1.116 vl.c
--- vl.c 15 Jan 2005 12:02:56 -0000 1.116
+++ vl.c 15 Jan 2005 19:10:31 -0000
@@ -1033,7 +1033,7 @@
void *fd_opaque;
} FDCharDriver;
-#define STDIO_MAX_CLIENTS 2
+#define STDIO_MAX_CLIENTS 3
static int stdio_nb_clients;
static CharDriverState *stdio_clients[STDIO_MAX_CLIENTS];
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] parallel and -nographic
2005-01-15 19:23 [Qemu-devel] [PATCH] parallel and -nographic Magnus Damm
@ 2005-01-15 20:20 ` Fabrice Bellard
2005-01-15 21:26 ` Magnus Damm
0 siblings, 1 reply; 3+ messages in thread
From: Fabrice Bellard @ 2005-01-15 20:20 UTC (permalink / raw)
To: qemu-devel
Hi,
I think the bug comes from the fact that the parallel port is redirected
to stdio in -nographic mode. I see no reason to do that.
Fabrice.
Magnus Damm wrote:
> Hello,
>
> The recent parallel port change broke -nographic. Without this patch
> "qemu -nographic" fails and outputs the following error:
>
> qemu: could not open parallel device 'stdio'
>
> / magnus
>
> Index: vl.c
> ===================================================================
> RCS file: /cvsroot/qemu/qemu/vl.c,v
> retrieving revision 1.116
> diff -u -r1.116 vl.c
> --- vl.c 15 Jan 2005 12:02:56 -0000 1.116
> +++ vl.c 15 Jan 2005 19:10:31 -0000
> @@ -1033,7 +1033,7 @@
> void *fd_opaque;
> } FDCharDriver;
>
> -#define STDIO_MAX_CLIENTS 2
> +#define STDIO_MAX_CLIENTS 3
>
> static int stdio_nb_clients;
> static CharDriverState *stdio_clients[STDIO_MAX_CLIENTS];
>
>
> _______________________________________________
> Qemu-devel mailing list
> Qemu-devel@nongnu.org
> http://lists.nongnu.org/mailman/listinfo/qemu-devel
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] parallel and -nographic
2005-01-15 20:20 ` Fabrice Bellard
@ 2005-01-15 21:26 ` Magnus Damm
0 siblings, 0 replies; 3+ messages in thread
From: Magnus Damm @ 2005-01-15 21:26 UTC (permalink / raw)
To: qemu-devel
Hello,
On Sat, 15 Jan 2005 21:20:47 +0100, Fabrice Bellard <fabrice@bellard.org> wrote:
> I think the bug comes from the fact that the parallel port is redirected
> to stdio in -nographic mode. I see no reason to do that.
Neither do I. But I was not sure - therefore the workaroundish patch.. =)
/ magnus
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-01-15 21:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-01-15 19:23 [Qemu-devel] [PATCH] parallel and -nographic Magnus Damm
2005-01-15 20:20 ` Fabrice Bellard
2005-01-15 21:26 ` Magnus Damm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).