[Qemu-devel] [PATCH] parallel and -nographic

[Qemu-devel] [PATCH] parallel and -nographic

[Magnus Damm]

Hello,

The recent parallel port change broke -nographic. Without this patch
"qemu -nographic" fails and outputs the following error:

qemu: could not open parallel device 'stdio'

/ magnus

Index: vl.c
===================================================================
RCS file: /cvsroot/qemu/qemu/vl.c,v
retrieving revision 1.116
diff -u -r1.116 vl.c
--- vl.c	15 Jan 2005 12:02:56 -0000	1.116
+++ vl.c	15 Jan 2005 19:10:31 -0000
@@ -1033,7 +1033,7 @@
     void *fd_opaque;
 } FDCharDriver;
 
-#define STDIO_MAX_CLIENTS 2
+#define STDIO_MAX_CLIENTS 3
 
 static int stdio_nb_clients;
 static CharDriverState *stdio_clients[STDIO_MAX_CLIENTS];

Re: [Qemu-devel] [PATCH] parallel and -nographic

[Fabrice Bellard]

Hi,

I think the bug comes from the fact that the parallel port is redirected 
to stdio in -nographic mode. I see no reason to do that.

Fabrice.

Magnus Damm wrote:
> Hello,
> 
> The recent parallel port change broke -nographic. Without this patch
> "qemu -nographic" fails and outputs the following error:
> 
> qemu: could not open parallel device 'stdio'
> 
> / magnus
> 
> Index: vl.c
> ===================================================================
> RCS file: /cvsroot/qemu/qemu/vl.c,v
> retrieving revision 1.116
> diff -u -r1.116 vl.c
> --- vl.c	15 Jan 2005 12:02:56 -0000	1.116
> +++ vl.c	15 Jan 2005 19:10:31 -0000
> @@ -1033,7 +1033,7 @@
>      void *fd_opaque;
>  } FDCharDriver;
>  
> -#define STDIO_MAX_CLIENTS 2
> +#define STDIO_MAX_CLIENTS 3
>  
>  static int stdio_nb_clients;
>  static CharDriverState *stdio_clients[STDIO_MAX_CLIENTS];
> 
> 
> _______________________________________________
> Qemu-devel mailing list
> Qemu-devel@nongnu.org
> http://lists.nongnu.org/mailman/listinfo/qemu-devel
> 
> 
> 

Re: [Qemu-devel] [PATCH] parallel and -nographic

[Magnus Damm]

Hello,

On Sat, 15 Jan 2005 21:20:47 +0100, Fabrice Bellard <fabrice@bellard.org> wrote:
> I think the bug comes from the fact that the parallel port is redirected
> to stdio in -nographic mode. I see no reason to do that.

Neither do I. But I was not sure - therefore the workaroundish patch.. =)

/ magnus