From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1CqfEu-0006hO-EJ for qemu-devel@nongnu.org; Mon, 17 Jan 2005 17:20:48 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1CqfEp-0006Ze-4c for qemu-devel@nongnu.org; Mon, 17 Jan 2005 17:20:43 -0500 Received: from [129.104.30.34] (helo=mx1.polytechnique.org) by monty-python.gnu.org with esmtp (Exim 4.34) id 1CqevK-0007Yo-2e for qemu-devel@nongnu.org; Mon, 17 Jan 2005 17:00:34 -0500 Received: from localhost (localhost [127.0.0.1]) by djali.polytechnique.org (Postfix) with ESMTP id DDEC4331A7 for ; Mon, 17 Jan 2005 23:00:32 +0100 (CET) Received: from djali.polytechnique.org ([127.0.0.1]) by localhost (localhost [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 12526-10 for ; Mon, 17 Jan 2005 23:00:32 +0100 (CET) Received: from [84.99.204.73] (unknown [84.99.204.73]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ssl.polytechnique.org (Postfix) with ESMTP id 89009331C3 for ; Mon, 17 Jan 2005 23:00:29 +0100 (CET) Message-ID: <41EC35AC.7090006@bellard.org> Date: Mon, 17 Jan 2005 23:01:16 +0100 From: Fabrice Bellard MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] Port E9 hack, for debugging purposes References: <41E94DA5.9030809@enix.org> <41EBC1FB.8050506@enix.org> In-Reply-To: <41EBC1FB.8050506@enix.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org There are already similar debug features in hw/pc.c for the Bochs BIOS,=20 but they are not enabled by default because I consider there were useful=20 only in rare cases. I would accept the "e9 hack" only if it was dynamically configurable and=20 if it used a generic character device (as the serial or parallel ports)=20 to output its results. The command line option should be '-port-e9=20 stdio' or something similar. Fabrice. Thomas Petazzoni wrote: > Hello, >=20 > Johannes Schindelin a =E9crit : >=20 >> I like it. It's simple and elegant, and your patch seems correct to me= . >=20 >=20 > Thanks. >=20 > After sending the patch, I thought that maybe it would be better to=20 > transform the configure time option to enable/disable the port E9 hack=20 > into a runtime option. >=20 > Currently, devices are not enabled/disabled through compile time=20 > options, but through runtime options. Doing it the same way for port E9= =20 > hack may be more coherent. >=20 > What do you think ? >=20 > Thomas >=20 >=20 > -----------------------------------------------------------------------= - >=20 > _______________________________________________ > Qemu-devel mailing list > Qemu-devel@nongnu.org > http://lists.nongnu.org/mailman/listinfo/qemu-devel