qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fabrice Bellard <fabrice@bellard.org>
To: qemu-devel@nongnu.org, de@axiros.com
Subject: Re: [Qemu-devel] [PATCH] Fix OS X SDL breakage
Date: Wed, 26 Jan 2005 20:47:15 +0100	[thread overview]
Message-ID: <41F7F3C3.9080401@bellard.org> (raw)
In-Reply-To: <89534439-6D8E-11D9-A061-000A958E35DC@axiros.com>

Can you confirm that QEMU for OS X works with this include ? IMHO it was 
added to add the '#define main SDL_main' define.

Fabrice.

Daniel Egger wrote:
> Hija,
> 
> On OS X vl.c explicitly includes <SDL/SDL.h> which is wrong for two
> reasons:
> a) the file does compile without the include
> b) the path is supposedly incorrect since the include path
>    is (should) be set by `sdl-config --cflags` which already
>    includes the path "SDL". So this will only work in case
>    someone tries to be clever by copying the SDL headers into
>    a directory SDL in a standard include directory and breaks
>    e.g. on fink where this is not the case.
> 
> Attached patch fixes this by removing the seemingly unneeded
> include.
> 
> 
> 
> Servus,
>       Daniel
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Qemu-devel mailing list
> Qemu-devel@nongnu.org
> http://lists.nongnu.org/mailman/listinfo/qemu-devel

  reply	other threads:[~2005-01-26 20:00 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-23 22:31 [Qemu-devel] [PATCH] Fix OS X SDL breakage Daniel Egger
2005-01-26 19:47 ` Fabrice Bellard [this message]
2005-01-26 20:47   ` Daniel Egger
2005-01-26 20:58   ` Laurent Amon
2005-01-27  7:53     ` Daniel Egger
2005-01-27 10:51       ` Laurent Amon
2005-01-27 11:40         ` Johannes Schindelin
2005-01-27 12:08           ` René Korthaus
2005-01-27 17:07             ` Daniel Egger
2005-01-27 22:39             ` Daniel Egger
2005-01-27 23:01             ` Laurent Amon
2005-01-27 13:27         ` [Qemu-devel] " Anand Kumria
2005-01-27 17:10           ` Daniel Egger
2005-01-27 19:34             ` Laurent Amon
2005-01-27 21:39               ` Daniel Egger
2005-01-27 21:33         ` [Qemu-devel] " Daniel Egger
  -- strict thread matches above, loose matches on Subject: below --
2005-01-30 20:21 Bernhard Ehlers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41F7F3C3.9080401@bellard.org \
    --to=fabrice@bellard.org \
    --cc=de@axiros.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).