* [PATCH] tcg: Allow displaying TCG_TYPE_I128 arguments
@ 2023-02-22 21:28 Philippe Mathieu-Daudé
2023-02-22 22:36 ` Richard Henderson
0 siblings, 1 reply; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-02-22 21:28 UTC (permalink / raw)
To: qemu-devel
Cc: Alex Bennée, Richard Henderson, Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
tcg/tcg.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tcg/tcg.c b/tcg/tcg.c
index a4a3da6804..3df2c6a6af 100644
--- a/tcg/tcg.c
+++ b/tcg/tcg.c
@@ -1955,6 +1955,7 @@ static char *tcg_get_arg_str_ptr(TCGContext *s, char *buf, int buf_size,
break;
#if TCG_TARGET_REG_BITS > 32
case TCG_TYPE_I64:
+ case TCG_TYPE_I128:
snprintf(buf, buf_size, "$0x%" PRIx64, ts->val);
break;
#endif
--
2.38.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] tcg: Allow displaying TCG_TYPE_I128 arguments
2023-02-22 21:28 [PATCH] tcg: Allow displaying TCG_TYPE_I128 arguments Philippe Mathieu-Daudé
@ 2023-02-22 22:36 ` Richard Henderson
2023-02-23 15:42 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 3+ messages in thread
From: Richard Henderson @ 2023-02-22 22:36 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel; +Cc: Alex Bennée
On 2/22/23 11:28, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> tcg/tcg.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tcg/tcg.c b/tcg/tcg.c
> index a4a3da6804..3df2c6a6af 100644
> --- a/tcg/tcg.c
> +++ b/tcg/tcg.c
> @@ -1955,6 +1955,7 @@ static char *tcg_get_arg_str_ptr(TCGContext *s, char *buf, int buf_size,
> break;
> #if TCG_TARGET_REG_BITS > 32
> case TCG_TYPE_I64:
> + case TCG_TYPE_I128:
> snprintf(buf, buf_size, "$0x%" PRIx64, ts->val);
This would be for a 128-bit constant, which we don't have.
Is this a guess, or hitting the assert, or what?
r~
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] tcg: Allow displaying TCG_TYPE_I128 arguments
2023-02-22 22:36 ` Richard Henderson
@ 2023-02-23 15:42 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-02-23 15:42 UTC (permalink / raw)
To: Richard Henderson, qemu-devel; +Cc: Alex Bennée
On 22/2/23 23:36, Richard Henderson wrote:
> On 2/22/23 11:28, Philippe Mathieu-Daudé wrote:
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>> ---
>> tcg/tcg.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/tcg/tcg.c b/tcg/tcg.c
>> index a4a3da6804..3df2c6a6af 100644
>> --- a/tcg/tcg.c
>> +++ b/tcg/tcg.c
>> @@ -1955,6 +1955,7 @@ static char *tcg_get_arg_str_ptr(TCGContext *s,
>> char *buf, int buf_size,
>> break;
>> #if TCG_TARGET_REG_BITS > 32
>> case TCG_TYPE_I64:
>> + case TCG_TYPE_I128:
>> snprintf(buf, buf_size, "$0x%" PRIx64, ts->val);
>
> This would be for a 128-bit constant, which we don't have.
> Is this a guess, or hitting the assert, or what?
Doh, right... Guessing while reviewing abort() / assert(0) /
g_assert_not_reached() calls :)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-02-23 15:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-22 21:28 [PATCH] tcg: Allow displaying TCG_TYPE_I128 arguments Philippe Mathieu-Daudé
2023-02-22 22:36 ` Richard Henderson
2023-02-23 15:42 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).