From: John Snow <jsnow@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
qemu-block@nongnu.org, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
ehabkost@redhat.com, Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 1/4] iotests: add script_initialize
Date: Thu, 29 Aug 2019 14:43:20 -0400 [thread overview]
Message-ID: <41d1edcf-ed61-6287-1019-4f779ffa3c79@redhat.com> (raw)
In-Reply-To: <5c7555f2-fba0-29fc-8bcd-bc68e5b42c63@redhat.com>
On 8/29/19 2:27 PM, Philippe Mathieu-Daudé wrote:
> This restrict test 208 to the Linux platform, is this OK?
>
> The rest looks good.
I forgot about that, so good catch.
I don't know. We seem to already restrict a LOT of tests to the Linux
platform. Does this one actually work on other platforms?
Actually, I can't see any other supported oses/supported platforms calls
anywhere in iotests that don't just specify Linux or leave it the
default (...which is also linux.)
There isn't a way to engage the old-style python unittest framework
without implying Linux; you have to manually override it if so.
For new tests, MOST of them specified Linux in some way or another, as
you saw.
So either:
- 208 was an oversight, or
- Many tests are accidentally limiting to Linux and could be loosened.
Which is it? Dunno. Guess I'll look at the VM tests to see if I can
co-opt some of that... stay tuned?
--js
next prev parent reply other threads:[~2019-08-29 18:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-20 23:52 [Qemu-devel] [PATCH v3 0/4] iotests: use python logging John Snow
2019-08-20 23:52 ` [Qemu-devel] [PATCH v3 1/4] iotests: add script_initialize John Snow
2019-08-29 18:27 ` Philippe Mathieu-Daudé
2019-08-29 18:43 ` John Snow [this message]
2019-08-29 18:58 ` Philippe Mathieu-Daudé
2019-08-29 19:36 ` John Snow
2019-08-20 23:52 ` [Qemu-devel] [PATCH v3 2/4] iotest 258: use script_main John Snow
2019-08-29 18:28 ` Philippe Mathieu-Daudé
2019-08-20 23:52 ` [Qemu-devel] [PATCH v3 3/4] iotests: add protocol support to initialization info John Snow
2019-08-29 18:30 ` Philippe Mathieu-Daudé
2019-08-20 23:52 ` [Qemu-devel] [PATCH v3 4/4] iotests: use python logging for iotests.log() John Snow
2019-08-29 18:34 ` Philippe Mathieu-Daudé
2019-08-29 18:51 ` John Snow
2019-08-21 0:10 ` [Qemu-devel] [PATCH v3 0/4] iotests: use python logging no-reply
2019-08-21 17:55 ` John Snow
2019-08-29 1:30 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41d1edcf-ed61-6287-1019-4f779ffa3c79@redhat.com \
--to=jsnow@redhat.com \
--cc=ehabkost@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).