From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 40DECC3065C for ; Tue, 2 Jul 2024 23:09:04 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sOmbv-0002Ow-0F; Tue, 02 Jul 2024 19:08:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sOmbt-0002OC-9z for qemu-devel@nongnu.org; Tue, 02 Jul 2024 19:08:29 -0400 Received: from mail-pl1-x62e.google.com ([2607:f8b0:4864:20::62e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sOmbq-0008KL-82 for qemu-devel@nongnu.org; Tue, 02 Jul 2024 19:08:28 -0400 Received: by mail-pl1-x62e.google.com with SMTP id d9443c01a7336-1f4c7b022f8so34610405ad.1 for ; Tue, 02 Jul 2024 16:08:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1719961704; x=1720566504; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=iMJnsQvYtn2ovyexs2uGpSE8+Bh9X/JzOCx3NzsQ5Ow=; b=pCJg1b/cHK0ntNVVggWamc0lmw6hzrP1qEMg0ybLDbzuYxiWU6VuYJlUPFUOrG8+8V wXc4HgUc7pKH49eieXy5w/BtsxD6xKHrrndD6QEo+Lx0DSNyOwOaUxaJpeHsLiy220dI KAjSDpp75IXEZovTaHup1s6p0TTvyaFR0FJr7S9rRefbCLbxcSIwXnCSznEECIxQAEZT u0ErgtULwbpmC6bynmX7raOEMsgBdb+FMdNzocUIhcIH0sFWomvUc31IIpYWcIiyu8eW 9zoybukI2jA5w1TqytKSU0dfbhRwfTccsJWSSIGiezeJ9vmKGnVMw/JrbRUgA1bwE6Ih 3iRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719961704; x=1720566504; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iMJnsQvYtn2ovyexs2uGpSE8+Bh9X/JzOCx3NzsQ5Ow=; b=ABOLqELf/M7ZIZD4r27H4xSiJcfEPLu1w5PqGoJlmn8iFoGrVBVX6vyeattjivBlUZ 4nai40NCX7AuVXsLMS9dNo+vMuPUf4oiDc/PTGGvY1eM5oqeKY89opddpSZeN1kSdzv9 6+P6c9XoBtfpfjfinWKbOsRTIAlovuej3Yt8FaOMxJBZRQUdtPdilghmorNHXvo62S8l qOo1p3iBmL8RiZOqiQAp/xVpVDK65TTz/E3ucfi9mnW15tzsUNa0ipiiRPdkzhLNIvaz uo2q62Sa6/CCUZaqy15NLqR72VaZTjODf5ROn8rVBDI3VTHj/hE1PY2NWsVX7Go6quHy HT7A== X-Forwarded-Encrypted: i=1; AJvYcCVG78JPG/7m/SX2B3+pa+iqUiHSomSFmxmfhDVLIIKtUeAbhiWaVqAP+RlE8W3f1x41jCSv5K6wFj7gxKNCuA4jFKotZeY= X-Gm-Message-State: AOJu0YzCHJ0JiE85swS6w9PSgGfo9HY7dGnFpx7Dn+A5nUu2gK7zEWJj YerKTP18o3dYR5X7bkbQOoM9NSW2uJUq3orfzLaI5T6wa9adhslJqx68RoD7zJ3Bqtat4WvPnZE X X-Google-Smtp-Source: AGHT+IF23JFdH5WGbhdvoCCe7OgK5NlvhswWrv2UEdsiBi5YJVuUzWvEkzZktBQedcZkDlZiSZcwgw== X-Received: by 2002:a17:902:b192:b0:1f6:fbde:9b96 with SMTP id d9443c01a7336-1fadbcfce9fmr70880745ad.59.1719961704329; Tue, 02 Jul 2024 16:08:24 -0700 (PDT) Received: from [192.168.0.4] (174-21-76-141.tukw.qwest.net. [174.21.76.141]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fac0ba60a2sm92262615ad.0.2024.07.02.16.08.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Jul 2024 16:08:23 -0700 (PDT) Message-ID: <41d6aa5b-5356-4048-8ef6-291a058f4197@linaro.org> Date: Tue, 2 Jul 2024 16:08:21 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] util/cpuinfo-riscv: Use linux __riscv_hwprobe syscall To: Daniel Henrique Barboza , qemu-devel@nongnu.org Cc: brad@comstyle.com, Alistair.Francis@wdc.com, palmer@dabbelt.com, qemu-riscv@nongnu.org References: <20240627180350.128575-1-richard.henderson@linaro.org> <20240627180350.128575-4-richard.henderson@linaro.org> <793a6bbe-5ac6-400c-b02b-9893a8887ee0@ventanamicro.com> Content-Language: en-US From: Richard Henderson In-Reply-To: <793a6bbe-5ac6-400c-b02b-9893a8887ee0@ventanamicro.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::62e; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x62e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 7/2/24 15:15, Daniel Henrique Barboza wrote: > > > On 6/27/24 3:03 PM, Richard Henderson wrote: >> With recent linux kernels, there is a syscall to probe for various >> ISA extensions.  These bits were phased in over several kernel >> releases, so we still require checks for symbol availability. >> >> Signed-off-by: Richard Henderson >> --- >>   meson.build          |  6 ++++++ >>   util/cpuinfo-riscv.c | 26 ++++++++++++++++++++++++++ >>   2 files changed, 32 insertions(+) >> >> diff --git a/meson.build b/meson.build >> index 97e00d6f59..58afd0125d 100644 >> --- a/meson.build >> +++ b/meson.build >> @@ -2837,6 +2837,12 @@ have_cpuid_h = cc.links(''' >>     }''') >>   config_host_data.set('CONFIG_CPUID_H', have_cpuid_h) >> +# Don't bother to advertise asm/hwprobe.h for old versions that do >> +# not contain RISCV_HWPROBE_EXT_ZBA. >> +config_host_data.set('CONFIG_ASM_HWPROBE_H', >> +                     cc.has_header_symbol('asm/hwprobe.h', >> +                                          'RISCV_HWPROBE_EXT_ZBA')) >> + > > FWIW I looked around Linux and I think we can snapshot hwprobe support by > checking for RISCV_HWPROBE_KEY_IMA_EXT_0 (Linux commit 162e4df137c) if we > ever need hwprobe for exts earlier than ZBA (C and V). Sure. It'll take some effort to use RVV for TCG vector operations. :-) > > Checking for ZBA is fine for this patch though. > > > Reviewed-by: Daniel Henrique Barboza Thanks. r~