From: Thomas Huth <thuth@redhat.com>
To: Yi Wang <wang.yi59@zte.com.cn>, qemu-devel@nongnu.org
Cc: xue.zhihong@zte.com.cn, QEMU Trivial <qemu-trivial@nongnu.org>,
wang.liang82@zte.com.cn, Liao Pingfang <liao.pingfang@zte.com.cn>,
Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [PATCH 07/12] vnc: Remove the superfluous break
Date: Mon, 13 Jul 2020 11:35:39 +0200 [thread overview]
Message-ID: <41e392cd-bb46-242f-197d-a82f6e277df9@redhat.com> (raw)
In-Reply-To: <1594631086-36509-1-git-send-email-wang.yi59@zte.com.cn>
On 13/07/2020 11.04, Yi Wang wrote:
> From: Liao Pingfang <liao.pingfang@zte.com.cn>
>
> Remove the superfluous break, as there is a "return" before.
>
> Signed-off-by: Liao Pingfang <liao.pingfang@zte.com.cn>a
> Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> ui/vnc-enc-tight.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/ui/vnc-enc-tight.c b/ui/vnc-enc-tight.c
> index 1e08518..cebd358 100644
> --- a/ui/vnc-enc-tight.c
> +++ b/ui/vnc-enc-tight.c
> @@ -1125,7 +1125,6 @@ static int send_palette_rect(VncState *vs, int x, int y,
> }
> default:
> return -1; /* No palette for 8bits colors */
> - break;
> }
> bytes = w * h;
> vs->tight->tight.offset = bytes;
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2020-07-13 9:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-13 9:04 [PATCH 07/12] vnc: Remove the superfluous break Yi Wang
2020-07-13 9:35 ` Thomas Huth [this message]
2020-09-01 6:37 ` Laurent Vivier
2020-07-13 10:02 ` Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41e392cd-bb46-242f-197d-a82f6e277df9@redhat.com \
--to=thuth@redhat.com \
--cc=kraxel@redhat.com \
--cc=liao.pingfang@zte.com.cn \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=wang.liang82@zte.com.cn \
--cc=wang.yi59@zte.com.cn \
--cc=xue.zhihong@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).