qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Hetz Ben Hamo" <hetzbh@gmail.com>
To: qemu-devel@nongnu.org
Cc: Wang Cheng Yeh <cywang.eda@gmail.com>
Subject: Re: [Qemu-devel] scsi interface patch
Date: Sun, 22 Apr 2007 12:54:05 +0300	[thread overview]
Message-ID: <41e41e7a0704220254p3da2ff36v1203fc2666ef65a@mail.gmail.com> (raw)
In-Reply-To: <a20f395e0704211901r52c39000y3db6be74e6854175@mail.gmail.com>

The "standard" way to submitting patches is unified diff's (diff -u)

Could you re-post your patch in unified format please?

Thanks,
Hetz

On 4/22/07, Wang Cheng Yeh <cywang.eda@gmail.com> wrote:
> The number of responded bytes from scsi device do not match the expected
> value of lsi53c895a driver.
> hence, the mismatch interrupt happen, but the driver does not always handle
> it correctly.
> My patch make the responded bytes as expected and the interrupt will not
> happen.
>
> Index: hw/scsi-disk.c
> ===================================================================
> RCS file: /sources/qemu/qemu/hw/scsi-disk.c,v
> retrieving revision 1.13
> diff -r1.13 scsi-disk.c
> 359c359
> <       memset(outbuf, 0, 36);
> ---
> >       memset(outbuf, 0, len);
> 377c377
> <       r->buf_len = 36;
> ---
> >       r->buf_len = len;
> 442a443,446
> >             for(;r->buf_len<len;r->buf_len++)
> >             {
> >                 *p++=0;
> >             }
>
>


-- 
Skepticism is the lazy person's default position.
Visit my blog (hebrew) for things that (sometimes) matter:
 http://wp.dad-answers.com

  reply	other threads:[~2007-04-22  9:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-22  2:01 [Qemu-devel] scsi interface patch Wang Cheng Yeh
2007-04-22  9:54 ` Hetz Ben Hamo [this message]
     [not found]   ` <a20f395e0704220615n268ca374y152fb23ad225ade7@mail.gmail.com>
2007-04-22 13:22     ` Wang Cheng Yeh
2007-04-22 13:54 ` Paul Brook
2007-04-22 15:26   ` Wang Cheng Yeh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41e41e7a0704220254p3da2ff36v1203fc2666ef65a@mail.gmail.com \
    --to=hetzbh@gmail.com \
    --cc=cywang.eda@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).