From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1HfYr3-0000yF-JG
	for qemu-devel@nongnu.org; Sun, 22 Apr 2007 05:59:37 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1HfYr1-0000y3-3z
	for qemu-devel@nongnu.org; Sun, 22 Apr 2007 05:59:36 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1HfYr0-0000y0-TY
	for qemu-devel@nongnu.org; Sun, 22 Apr 2007 05:59:34 -0400
Received: from ug-out-1314.google.com ([66.249.92.172])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <hetzbh@gmail.com>) id 1HfYlj-0005nj-IE
	for qemu-devel@nongnu.org; Sun, 22 Apr 2007 05:54:07 -0400
Received: by ug-out-1314.google.com with SMTP id j40so1057394ugd
	for <qemu-devel@nongnu.org>; Sun, 22 Apr 2007 02:54:06 -0700 (PDT)
Message-ID: <41e41e7a0704220254p3da2ff36v1203fc2666ef65a@mail.gmail.com>
Date: Sun, 22 Apr 2007 12:54:05 +0300
From: "Hetz Ben Hamo" <hetzbh@gmail.com>
Subject: Re: [Qemu-devel] scsi interface patch
In-Reply-To: <a20f395e0704211901r52c39000y3db6be74e6854175@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <a20f395e0704211901r52c39000y3db6be74e6854175@mail.gmail.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Wang Cheng Yeh <cywang.eda@gmail.com>

The "standard" way to submitting patches is unified diff's (diff -u)

Could you re-post your patch in unified format please?

Thanks,
Hetz

On 4/22/07, Wang Cheng Yeh <cywang.eda@gmail.com> wrote:
> The number of responded bytes from scsi device do not match the expected
> value of lsi53c895a driver.
> hence, the mismatch interrupt happen, but the driver does not always handle
> it correctly.
> My patch make the responded bytes as expected and the interrupt will not
> happen.
>
> Index: hw/scsi-disk.c
> ===================================================================
> RCS file: /sources/qemu/qemu/hw/scsi-disk.c,v
> retrieving revision 1.13
> diff -r1.13 scsi-disk.c
> 359c359
> <       memset(outbuf, 0, 36);
> ---
> >       memset(outbuf, 0, len);
> 377c377
> <       r->buf_len = 36;
> ---
> >       r->buf_len = len;
> 442a443,446
> >             for(;r->buf_len<len;r->buf_len++)
> >             {
> >                 *p++=0;
> >             }
>
>


-- 
Skepticism is the lazy person's default position.
Visit my blog (hebrew) for things that (sometimes) matter:
 http://wp.dad-answers.com