From: Pierrick Bouvier <pierrick.bouvier@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
kvm@vger.kernel.org, alex.bennee@linaro.org,
Marcelo Tosatti <mtosatti@redhat.com>,
"Maciej S. Szmigiero" <maciej.szmigiero@oracle.com>,
richard.henderson@linaro.org, manos.pitsidianakis@linaro.org
Subject: Re: [PATCH v4 0/7] hw/hyperv: remove duplication compilation units
Date: Fri, 7 Mar 2025 14:38:18 -0800 [thread overview]
Message-ID: <41e7da17-5f8b-4cae-8cab-36055f2b4794@linaro.org> (raw)
In-Reply-To: <fb8f0700-2676-4e7a-8857-ca10f5060b37@linaro.org>
On 3/7/25 14:06, Philippe Mathieu-Daudé wrote:
> On 7/3/25 22:56, Pierrick Bouvier wrote:
>> Work towards having a single binary, by removing duplicated object files.
>>
>> hw/hyperv/hyperv.c was excluded at this time, because it depends on target
>> dependent symbols:
>> - from system/kvm.h
>> - kvm_check_extension
>> - kvm_vm_ioctl
>
> Bug, these should be declared outside of COMPILING_PER_TARGET.
>
Yes, I noticed you solved it this way on one of your series.
In the end, since QEMU does not have any specific boundaries between
subsystems (i.e. no proper libraries with private/public symbols), we
are mostly free to include any symbol we see in an header as long as it
does not use a target dependent type which changes the signature.
>> - from exec/cpu-all.h | memory_ldst_phys.h.inc
>> - ldq_phys
>
> Yeah, not an easy one.
>
next prev parent reply other threads:[~2025-03-07 22:38 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-07 21:56 [PATCH v4 0/7] hw/hyperv: remove duplication compilation units Pierrick Bouvier
2025-03-07 21:56 ` [PATCH v4 1/7] hw/hyperv/hv-balloon-stub: common compilation unit Pierrick Bouvier
2025-03-07 21:56 ` [PATCH v4 2/7] hw/hyperv/hyperv.h: header cleanup Pierrick Bouvier
2025-03-11 15:05 ` Philippe Mathieu-Daudé
2025-03-11 15:14 ` Philippe Mathieu-Daudé
2025-03-07 21:56 ` [PATCH v4 3/7] hw/hyperv/vmbus: common compilation unit Pierrick Bouvier
2025-03-07 21:56 ` [PATCH v4 4/7] hw/hyperv/hyperv-proto: move SYNDBG definition from target/i386 Pierrick Bouvier
2025-03-07 21:56 ` [PATCH v4 5/7] hw/hyperv/syndbg: common compilation unit Pierrick Bouvier
2025-03-07 21:56 ` [PATCH v4 6/7] hw/hyperv/balloon: common balloon compilation units Pierrick Bouvier
2025-03-07 21:56 ` [PATCH v4 7/7] hw/hyperv/hyperv_testdev: common compilation unit Pierrick Bouvier
2025-03-07 22:06 ` [PATCH v4 0/7] hw/hyperv: remove duplication compilation units Philippe Mathieu-Daudé
2025-03-07 22:38 ` Pierrick Bouvier [this message]
2025-03-07 22:25 ` Philippe Mathieu-Daudé
2025-03-07 22:31 ` Maciej S. Szmigiero
2025-03-07 22:37 ` Philippe Mathieu-Daudé
2025-03-09 23:33 ` Pierrick Bouvier
2025-03-10 0:14 ` Philippe Mathieu-Daudé
2025-03-10 2:10 ` Pierrick Bouvier
2025-03-10 12:28 ` Maciej S. Szmigiero
2025-03-10 12:28 ` Maciej S. Szmigiero
2025-03-20 19:00 ` Pierrick Bouvier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41e7da17-5f8b-4cae-8cab-36055f2b4794@linaro.org \
--to=pierrick.bouvier@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=kvm@vger.kernel.org \
--cc=maciej.szmigiero@oracle.com \
--cc=manos.pitsidianakis@linaro.org \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).