From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Thomas Huth <thuth@redhat.com>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Magnus Damm <magnus.damm@gmail.com>
Subject: Re: [PATCH 2/3] hw/timer/sh_timer: Silence warnings about missing fallthrough statements
Date: Sat, 24 Oct 2020 22:10:08 +0200 [thread overview]
Message-ID: <41f00a68-b0ef-9c2c-6f69-3fe710aea2e4@amsat.org> (raw)
In-Reply-To: <20201020153935.54315-3-thuth@redhat.com>
On 10/20/20 5:39 PM, Thomas Huth wrote:
> When compiling with -Werror=implicit-fallthrough, gcc complains about
> missing fallthrough annotations in this file. Looking at the code,
> the fallthrough is very likely intended here, so add some comments
> to silence the compiler warnings.
>
Fixes: cd1a3f6840e ("Stand-alone TMU emulation code")
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> hw/timer/sh_timer.c | 4 ++++
> 1 file changed, 4 insertions(+)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
next prev parent reply other threads:[~2020-10-24 20:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-20 15:39 [PATCH 0/3] sh4: Trivial clean-ups for sh_timer.c Thomas Huth
2020-10-20 15:39 ` [PATCH 1/3] hw/timer/sh_timer: Coding style clean-up Thomas Huth
2020-10-24 20:06 ` Philippe Mathieu-Daudé
2020-10-20 15:39 ` [PATCH 2/3] hw/timer/sh_timer: Silence warnings about missing fallthrough statements Thomas Huth
2020-10-24 20:10 ` Philippe Mathieu-Daudé [this message]
2020-10-20 15:39 ` [PATCH 3/3] hw/timer/sh_timer: Remove superfluous "break" statements Thomas Huth
2020-10-24 20:10 ` Philippe Mathieu-Daudé
2020-10-21 16:48 ` [PATCH 0/3] sh4: Trivial clean-ups for sh_timer.c Richard Henderson
2020-10-25 0:38 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41f00a68-b0ef-9c2c-6f69-3fe710aea2e4@amsat.org \
--to=f4bug@amsat.org \
--cc=magnus.damm@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=thuth@redhat.com \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).