From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3D24AC433F5 for ; Fri, 25 Feb 2022 11:12:57 +0000 (UTC) Received: from localhost ([::1]:57168 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nNYWt-0007Xj-RU for qemu-devel@archiver.kernel.org; Fri, 25 Feb 2022 06:12:55 -0500 Received: from eggs.gnu.org ([209.51.188.92]:59758) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nNYTA-0006Rt-B8 for qemu-devel@nongnu.org; Fri, 25 Feb 2022 06:09:04 -0500 Received: from [2001:738:2001:2001::2001] (port=29839 helo=zero.eik.bme.hu) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nNYSz-00038P-OT for qemu-devel@nongnu.org; Fri, 25 Feb 2022 06:08:59 -0500 Received: from zero.eik.bme.hu (blah.eik.bme.hu [152.66.115.182]) by localhost (Postfix) with SMTP id EFC4674632B; Fri, 25 Feb 2022 12:08:19 +0100 (CET) Received: by zero.eik.bme.hu (Postfix, from userid 432) id C67C47462D3; Fri, 25 Feb 2022 12:08:19 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by zero.eik.bme.hu (Postfix) with ESMTP id C4A5E7456FE; Fri, 25 Feb 2022 12:08:19 +0100 (CET) Date: Fri, 25 Feb 2022 12:08:19 +0100 (CET) From: BALATON Zoltan To: qemu-devel@nongnu.org Subject: Re: [PATCH v2 0/5] Misc OHCI clean ups In-Reply-To: <228c70c7-11bf-8d94-607b-4eacdcaddd93@eik.bme.hu> Message-ID: <41fdb23c-8d12-1ffa-f08-601f15ffc7d6@eik.bme.hu> References: <1b24997-8dba-d640-1ce6-896fc346ae9@eik.bme.hu> <228c70c7-11bf-8d94-607b-4eacdcaddd93@eik.bme.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed X-Host-Lookup-Failed: Reverse DNS lookup failed for 2001:738:2001:2001::2001 (failed) Received-SPF: pass client-ip=2001:738:2001:2001::2001; envelope-from=balaton@eik.bme.hu; helo=zero.eik.bme.hu X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Gerd Hoffmann Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, 16 Feb 2022, BALATON Zoltan wrote: > On Tue, 8 Feb 2022, BALATON Zoltan wrote: >> On Tue, 25 Jan 2022, BALATON Zoltan wrote: >>> v2 - Fixed checkpatch errors >>> >>> Hello, >> >> Ping? > > Ping^2 Ping^3 > https://patchew.org/QEMU/cover.1643117600.git.balaton@eik.bme.hu/ > > Regards, > BALATON Zoltan > >>> I have these patches from last October when we've looked at what >>> causes problems with mac99 and USB. We've found the main problem is >>> likely not allowing pending packets per endpoint which we did not fix >>> but these patches came out of debugging that and trying to improve the >>> device model so eventually the real problem could be fixed more >>> easily. So these are just clean ups and fixing one potential issue >>> with isochronous transfers breaking pending async packet but it does >>> not solve all problems OHCI currently has. I'm sending it anyway as I >>> don't plan to work further on this so this series could be taken as is >>> for now. >>> >>> Regards, >>> >>> BALATON Zoltan (5): >>> usb/ohci: Move trace point and log ep number to help debugging >>> usb/ohci: Move cancelling async packet to ohci_stop_endpoints() >>> usb/ohci: Move USBPortOps related functions together >>> usb/ohci: Merge ohci_async_cancel_device() into ohci_child_detach() >>> usb/ohci: Don't use packet from OHCIState for isochronous transfers >>> >>> hw/usb/hcd-ohci.c | 297 +++++++++++++++++++++----------------------- >>> hw/usb/trace-events | 2 +- >>> 2 files changed, 146 insertions(+), 153 deletions(-) >>> >>> >> > >