qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fabrice Bellard <fabrice@bellard.org>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] qemu/hw openpic.c
Date: Thu, 10 Feb 2005 00:05:53 +0100	[thread overview]
Message-ID: <420A9751.6070803@bellard.org> (raw)
In-Reply-To: <1107974138.584.12.camel@localhost.localdomain>

This fix was already commited in the CVS.

Fabrice.

Thayne Harbaugh wrote:
> On Tue, 2005-02-08 at 19:01 -0500, Fabrice Bellard wrote:
> 
>>CVSROOT:	/cvsroot/qemu
>>Module name:	qemu
>>Branch: 	
>>Changes by:	Fabrice Bellard <bellard@savannah.gnu.org>	05/02/09 00:01:34
>>
>>Modified files:
>>	hw             : openpic.c 
>>
>>Log message:
>>	spelling fix
>>
>>CVSWeb URLs:
>>http://savannah.gnu.org/cgi-bin/viewcvs/qemu/qemu/hw/openpic.c.diff?tr1=1.5&tr2=1.6&r1=text&r2=text
> 
> 
> 
> There was another change in openpic.c that I haven't seen committed:
> 
> @@ -629,7 +629,7 @@
>          break;
>      case 0x10: /* TIBC */
>  	if ((opp->timers[idx].ticc & 0x80000000) != 0 &&
> -	    (val & 0x800000000) == 0 &&
> +	    (val & 0x80000000) == 0 &&
>              (opp->timers[idx].tibc & 0x80000000) != 0)
>  	    opp->timers[idx].ticc &= ~0x80000000;
>  	opp->timers[idx].tibc = val;
> 
> 
> It's because the constant 0x800000000 is larger than a uint32_t (it
> appears that the way it was will always cause "(val & 0x800000000) == 0"
> to always be true).  I haven't tested it - I just made the change
> because it looked "obvious".  Please let me know if there's some black
> magic that this "fix" breaks.
> 
> 
> 
> 
> _______________________________________________
> Qemu-devel mailing list
> Qemu-devel@nongnu.org
> http://lists.nongnu.org/mailman/listinfo/qemu-devel
> 
> 

  reply	other threads:[~2005-02-09 23:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-09  0:01 [Qemu-devel] qemu/hw openpic.c Fabrice Bellard
2005-02-09 18:35 ` Thayne Harbaugh
2005-02-09 23:05   ` Fabrice Bellard [this message]
  -- strict thread matches above, loose matches on Subject: below --
2005-06-05 14:50 Fabrice Bellard
2005-01-10 23:32 Fabrice Bellard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=420A9751.6070803@bellard.org \
    --to=fabrice@bellard.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).