From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Cz1A8-0006fH-Se
	for qemu-devel@nongnu.org; Wed, 09 Feb 2005 18:22:25 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Cz1A4-0006bl-U6
	for qemu-devel@nongnu.org; Wed, 09 Feb 2005 18:22:20 -0500
Received: from [129.104.30.34] (helo=mx1.polytechnique.org)
	by monty-python.gnu.org with esmtp (Exim 4.34) id 1Cz0tD-0007hw-PZ
	for qemu-devel@nongnu.org; Wed, 09 Feb 2005 18:04:55 -0500
Received: from [84.99.204.153] (153.204.99-84.rev.gaoland.net [84.99.204.153])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by ssl.polytechnique.org (Postfix) with ESMTP id CF14433172
	for <qemu-devel@nongnu.org>; Thu, 10 Feb 2005 00:04:52 +0100 (CET)
Message-ID: <420A9751.6070803@bellard.org>
Date: Thu, 10 Feb 2005 00:05:53 +0100
From: Fabrice Bellard <fabrice@bellard.org>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] qemu/hw openpic.c
References: <E1CyfIU-0002mL-00@savannah>
	<1107974138.584.12.camel@localhost.localdomain>
In-Reply-To: <1107974138.584.12.camel@localhost.localdomain>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

This fix was already commited in the CVS.

Fabrice.

Thayne Harbaugh wrote:
> On Tue, 2005-02-08 at 19:01 -0500, Fabrice Bellard wrote:
> 
>>CVSROOT:	/cvsroot/qemu
>>Module name:	qemu
>>Branch: 	
>>Changes by:	Fabrice Bellard <bellard@savannah.gnu.org>	05/02/09 00:01:34
>>
>>Modified files:
>>	hw             : openpic.c 
>>
>>Log message:
>>	spelling fix
>>
>>CVSWeb URLs:
>>http://savannah.gnu.org/cgi-bin/viewcvs/qemu/qemu/hw/openpic.c.diff?tr1=1.5&tr2=1.6&r1=text&r2=text
> 
> 
> 
> There was another change in openpic.c that I haven't seen committed:
> 
> @@ -629,7 +629,7 @@
>          break;
>      case 0x10: /* TIBC */
>  	if ((opp->timers[idx].ticc & 0x80000000) != 0 &&
> -	    (val & 0x800000000) == 0 &&
> +	    (val & 0x80000000) == 0 &&
>              (opp->timers[idx].tibc & 0x80000000) != 0)
>  	    opp->timers[idx].ticc &= ~0x80000000;
>  	opp->timers[idx].tibc = val;
> 
> 
> It's because the constant 0x800000000 is larger than a uint32_t (it
> appears that the way it was will always cause "(val & 0x800000000) == 0"
> to always be true).  I haven't tested it - I just made the change
> because it looked "obvious".  Please let me know if there's some black
> magic that this "fix" breaks.
> 
> 
> 
> 
> _______________________________________________
> Qemu-devel mailing list
> Qemu-devel@nongnu.org
> http://lists.nongnu.org/mailman/listinfo/qemu-devel
> 
>