* [Qemu-devel] qemu/hw openpic.c
@ 2005-02-09 0:01 Fabrice Bellard
2005-02-09 18:35 ` Thayne Harbaugh
0 siblings, 1 reply; 5+ messages in thread
From: Fabrice Bellard @ 2005-02-09 0:01 UTC (permalink / raw)
To: qemu-devel
CVSROOT: /cvsroot/qemu
Module name: qemu
Branch:
Changes by: Fabrice Bellard <bellard@savannah.gnu.org> 05/02/09 00:01:34
Modified files:
hw : openpic.c
Log message:
spelling fix
CVSWeb URLs:
http://savannah.gnu.org/cgi-bin/viewcvs/qemu/qemu/hw/openpic.c.diff?tr1=1.5&tr2=1.6&r1=text&r2=text
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] qemu/hw openpic.c
2005-02-09 0:01 [Qemu-devel] qemu/hw openpic.c Fabrice Bellard
@ 2005-02-09 18:35 ` Thayne Harbaugh
2005-02-09 23:05 ` Fabrice Bellard
0 siblings, 1 reply; 5+ messages in thread
From: Thayne Harbaugh @ 2005-02-09 18:35 UTC (permalink / raw)
To: qemu-devel
On Tue, 2005-02-08 at 19:01 -0500, Fabrice Bellard wrote:
> CVSROOT: /cvsroot/qemu
> Module name: qemu
> Branch:
> Changes by: Fabrice Bellard <bellard@savannah.gnu.org> 05/02/09 00:01:34
>
> Modified files:
> hw : openpic.c
>
> Log message:
> spelling fix
>
> CVSWeb URLs:
> http://savannah.gnu.org/cgi-bin/viewcvs/qemu/qemu/hw/openpic.c.diff?tr1=1.5&tr2=1.6&r1=text&r2=text
There was another change in openpic.c that I haven't seen committed:
@@ -629,7 +629,7 @@
break;
case 0x10: /* TIBC */
if ((opp->timers[idx].ticc & 0x80000000) != 0 &&
- (val & 0x800000000) == 0 &&
+ (val & 0x80000000) == 0 &&
(opp->timers[idx].tibc & 0x80000000) != 0)
opp->timers[idx].ticc &= ~0x80000000;
opp->timers[idx].tibc = val;
It's because the constant 0x800000000 is larger than a uint32_t (it
appears that the way it was will always cause "(val & 0x800000000) == 0"
to always be true). I haven't tested it - I just made the change
because it looked "obvious". Please let me know if there's some black
magic that this "fix" breaks.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Qemu-devel] qemu/hw openpic.c
2005-02-09 18:35 ` Thayne Harbaugh
@ 2005-02-09 23:05 ` Fabrice Bellard
0 siblings, 0 replies; 5+ messages in thread
From: Fabrice Bellard @ 2005-02-09 23:05 UTC (permalink / raw)
To: qemu-devel
This fix was already commited in the CVS.
Fabrice.
Thayne Harbaugh wrote:
> On Tue, 2005-02-08 at 19:01 -0500, Fabrice Bellard wrote:
>
>>CVSROOT: /cvsroot/qemu
>>Module name: qemu
>>Branch:
>>Changes by: Fabrice Bellard <bellard@savannah.gnu.org> 05/02/09 00:01:34
>>
>>Modified files:
>> hw : openpic.c
>>
>>Log message:
>> spelling fix
>>
>>CVSWeb URLs:
>>http://savannah.gnu.org/cgi-bin/viewcvs/qemu/qemu/hw/openpic.c.diff?tr1=1.5&tr2=1.6&r1=text&r2=text
>
>
>
> There was another change in openpic.c that I haven't seen committed:
>
> @@ -629,7 +629,7 @@
> break;
> case 0x10: /* TIBC */
> if ((opp->timers[idx].ticc & 0x80000000) != 0 &&
> - (val & 0x800000000) == 0 &&
> + (val & 0x80000000) == 0 &&
> (opp->timers[idx].tibc & 0x80000000) != 0)
> opp->timers[idx].ticc &= ~0x80000000;
> opp->timers[idx].tibc = val;
>
>
> It's because the constant 0x800000000 is larger than a uint32_t (it
> appears that the way it was will always cause "(val & 0x800000000) == 0"
> to always be true). I haven't tested it - I just made the change
> because it looked "obvious". Please let me know if there's some black
> magic that this "fix" breaks.
>
>
>
>
> _______________________________________________
> Qemu-devel mailing list
> Qemu-devel@nongnu.org
> http://lists.nongnu.org/mailman/listinfo/qemu-devel
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Qemu-devel] qemu/hw openpic.c
@ 2005-06-05 14:50 Fabrice Bellard
0 siblings, 0 replies; 5+ messages in thread
From: Fabrice Bellard @ 2005-06-05 14:50 UTC (permalink / raw)
To: qemu-devel
CVSROOT: /cvsroot/qemu
Module name: qemu
Branch:
Changes by: Fabrice Bellard <bellard@savannah.gnu.org> 05/06/05 14:50:39
Modified files:
hw : openpic.c
Log message:
more generic IRQ support
CVSWeb URLs:
http://savannah.gnu.org/cgi-bin/viewcvs/qemu/qemu/hw/openpic.c.diff?tr1=1.6&tr2=1.7&r1=text&r2=text
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Qemu-devel] qemu/hw openpic.c
@ 2005-01-10 23:32 Fabrice Bellard
0 siblings, 0 replies; 5+ messages in thread
From: Fabrice Bellard @ 2005-01-10 23:32 UTC (permalink / raw)
To: qemu-devel
CVSROOT: /cvsroot/qemu
Module name: qemu
Branch:
Changes by: Fabrice Bellard <bellard@savannah.gnu.org> 05/01/10 23:19:18
Modified files:
hw : openpic.c
Log message:
typo
CVSWeb URLs:
http://savannah.gnu.org/cgi-bin/viewcvs/qemu/qemu/hw/openpic.c.diff?tr1=1.4&tr2=1.5&r1=text&r2=text
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2005-06-05 14:55 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-02-09 0:01 [Qemu-devel] qemu/hw openpic.c Fabrice Bellard
2005-02-09 18:35 ` Thayne Harbaugh
2005-02-09 23:05 ` Fabrice Bellard
-- strict thread matches above, loose matches on Subject: below --
2005-06-05 14:50 Fabrice Bellard
2005-01-10 23:32 Fabrice Bellard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).